Cleanup.#513
Merged
Merged
Conversation
![olive-agent[bot]](https://avatars.githubusercontent.com/in/1216019?s=60&v=4){kind=small}
There was a problem hiding this comment.
formula-android/src/main/java/com/instacart/formula/android/RouteId.kt:24
Removing these deprecated Fragment* compatibility aliases and Fragment.getFormulaFragmentId() changes the published formula-android API surface in a breaking way. In particular, deleting getFormulaFragmentId() removes a JVM method that already-compiled consumers can still call, which can turn into NoSuchMethodError until they recompile. The alias removals in this cleanup are also source-breaking for Kotlin callers. If this is intended, it should land as part of the coordinated breaking-release/versioning/docs work; otherwise the deprecated forwarding API should stay in place for now.
JaCoCo Code Coverage 93.83% ✅
Generated by 🚫 Danger |
📊 Benchmark Comparison ReportSummary
🎉 Performance Improvements
No significant changes (3 benchmarks)
Regressions: ±10% with non-overlapping confidence intervals. Improvements: ±10% change only. Generated by 🚫 Danger |
Laimiux
reviewed
May 20, 2026
| } | ||
|
|
||
| private val formulaRouteId: RouteId<*> by lazy { | ||
| private val formulaRouteId: RouteId<*> by lazy(LazyThreadSafetyMode.NONE) { |
Collaborator
There was a problem hiding this comment.
This is only internally used from main thread?
Collaborator
Author
There was a problem hiding this comment.
Correct:
- 1st call in
onCreateViewis guaranteed main thread - 2nd call in
onCreateView(withinsetContentrecomposition) may potentially be non-main, butformulaRouteIdshould always be already initialized at that point (by the 1st call) setState->updateVisibleFragments()->onFragmentViewCreated()- guaranteed main threadsetState->updateVisibleFragments()->render()- guaranteed main thread due to priorUtils.assertMainThread()
Laimiux
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.