Repository navigation
Upgrade perspective/webui Gradle examples to io.ia.sdk.modl 0.5.0 - #211
Open
sankalpsthakur wants to merge 1 commit into
Open
sankalpsthakur wants to merge 1 commit into
sankalpsthakur wants to merge 1 commit into
Conversation
Align Gradle module examples with immutable-project: bump the Ignition module plugin to 0.5.0 and migrate Perspective module deps to moduleDependencySpecs (required for Ignition 8.3). Resolves the java-library + CollectModlDependencies/SyncSpec apply failure reported when upgrading past 0.1.1 (inductiveautomation#119). Also verified ignition-8.3 already uses jakarta.servlet and requiredIgnitionVersion 8.3.0 for Jetty 12 (inductiveautomation#134). Plugin upgrade improves collectModlDependencies jar inputs, which helps zipModule rebuild when Java/resource sources change (inductiveautomation#96).
Author
|
Hi, gentle ping on this when someone has a moment. Happy to adjust anything. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #119 by upgrading the module plugin from 0.1.1 to 0.5.0 in
perspective-component,perspective-component-minimalandwebui-webpage.The Perspective examples use
moduleDependencySpecswith the required Perspective dependency. The webpage example drops its empty deprecated dependency map. The full component example also setsrequiredFrameworkVersion = "8".Validation
Previously reported local validation used Java 17 and the existing Gradle wrappers: configuration tasks for all three examples and
zipModulefor the minimal component example. Those runs succeeded; they were not rerun for this description update. The generated module remains unsigned for development use. This PR does not establish gateway deployment acceptance.Related issues #134 and #96 cover servlet migration and incremental module packaging; neither is claimed resolved by this change.
AI disclosure
Grok assisted with the contribution. Codex assisted with this description update.