Sync generator templates toward ignition-sdk-examples (Fixes #70) - #78
Open
sankalpsthakur wants to merge 1 commit into
Open
sankalpsthakur wants to merge 1 commit into
sankalpsthakur wants to merge 1 commit into
Conversation
…eautomation#70) Bring generated module skeletons closer to the current 8.3 reference examples without breaking intentional multi-version Gradle wrapper support. - Default Ignition SDK version: 8.1.20 -> 8.3.0 - Emit gradle/libs.versions.toml (examples-style catalog) and resolve compileOnly deps via libs.ignition.* instead of string interpolation - Align settings DSL with buildscript DSL (Kotlin projects get settings.gradle.kts); fix settingsFilename() resource path bug - Add deepClean task to root buildscripts (matches examples) - Simplify Gateway/Designer hook stubs to 8.3-compatible lifecycle APIs (remove removed javax.servlet / overview contributor overrides) Left unchanged intentionally (already ahead of the issue, or multi-version): - Java toolchain remains 25 (set by inductiveautomation#75 for this tools line) - Default Gradle wrapper remains 9.3.1 (set by inductiveautomation#75) - modl plugin version remains 1.0.0 (repo version; examples still pin older) Validation: ./gradlew genTest; generated GCD kotlin + G groovy projects build successfully against published plugin from mavenLocal + SDK 8.3.0. AI disclosure: assisted by an AI coding agent; human-reviewed before PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #70 by updating generated module skeletons for the 8.3 line of ignition-sdk-examples.
gradle/libs.versions.toml.deepCleantask and update Gateway/Designer lifecycle stubs for 8.3 APIs.The existing Java 25, Gradle 9.3.1 and plugin 1.0.0 defaults remain. Older Gradle wrapper bundles remain available.
Validation
Generator tests and local publication passed on Java 25. Generated Kotlin multi-scope and Groovy single-scope projects built successfully against SDK 8.3.0 using the locally published plugin with module signing skipped.
AI coding tools assisted with the implementation and this description.