Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
|
Thanks for contribution! 🎉 To test the changes please execute: before executing the recipes. |
… edition recipes Co-Authored-By: Claude <noreply@anthropic.com>
| ibexa.featured: | ||
| resource: '@IbexaFeaturedBundle/Resources/config/routing.yaml' | ||
| defaults: | ||
| siteaccess_group_whitelist: '%admin_group_name%' |
There was a problem hiding this comment.
Caution
These defaults are dead config ATM. routing.controllers from the project's config/routes.yaml re-registers the attribute route under the same name, so the whitelist never lands on ibexa.featured.page (verified via debug:router on an instance with this recipe). Proposed moving it to the #[Route] attribute in https://github.com/ibexa/featured/pull/1#discussion_r4120873955.
Once that's in, I'd drop it here and in the headless, experience and commerce copies, so nobody assumes this is what protects the route.
| ibexa.featured: | |
| resource: '@IbexaFeaturedBundle/Resources/config/routing.yaml' | |
| defaults: | |
| siteaccess_group_whitelist: '%admin_group_name%' | |
| ibexa.featured: | |
| resource: '@IbexaFeaturedBundle/Resources/config/routing.yaml' |
🤖 Generated with Claude Code
… attribute route The SiteAccess group whitelist lives on the controller's route attribute since ibexa/featured#1. Co-Authored-By: Claude <noreply@anthropic.com>
|
5 participants
Related PRs:
Description:
Recipes for two packages entering the product through
ibexa/headless:ibexa/featured— registers the bundle and shipsconfig/routes/ibexa_featured.yaml(promotional Engagement / Personalization pages).ibexa/admin-ui-extras— registers the bundle (no configuration to copy).Following the IBX-12397 precedent (#261), both bundles are also registered in the
headless,experienceandcommerce6.0 edition recipes, together with the featured routes file.For QA:
Install with
composer config extra.symfony.endpoint https://api.github.com/repos/ibexa/recipes-dev/contents/index.json?ref=flex/pull-265:config/bundles.phplists both bundles andconfig/routes/ibexa_featured.yamlis present.Documentation:
None.