Repository navigation
Conversation
|
ibexa-workflow-automation-1
Bot
requested review from
Steveb-p,
ViniTou,
alongosz,
barw4,
bnowak,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
August 27, 2026 06:02
bnowak
approved these changes
Sep 3, 2026
konradoboza
approved these changes
Sep 7, 2026
mikadamczyk
reviewed
Sep 23, 2026
mikadamczyk
left a comment
mikadamczyk
left a comment
Contributor
There was a problem hiding this comment.
PasswordResetTest and UserInvitationTest share an almost identical structure. Could we extract the shared mock wiring into a base test class to avoid maintaining the same pattern twice?
| LoggerInterface $logger | ||
| ): PasswordReset { | ||
| $configResolver = $this->createMock(ConfigResolverInterface::class); | ||
| $configResolver |
Contributor
There was a problem hiding this comment.
$configResolver->method('getParameter') has no ->expects(). Could we add ->expects(self::once()) or atLeastOnce()
| LoggerInterface $logger | ||
| ): UserInvitation { | ||
| $configResolver = $this->createMock(ConfigResolverInterface::class); | ||
| $configResolver |
Contributor
There was a problem hiding this comment.
$configResolver->method('getParameter') has no ->expects()
juskora
force-pushed
the
IBX-12339_notifier_does_not_log_when_unconfigured
branch
from
October 9, 2026 09:24
be4f62b to
0880aaa
Compare
|
mikadamczyk
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
[TMP]commit before merging. It addsibexa/doctrine-migrationstorequire-devIt can be removed once IBX-12840: Bumped ibexa/code-style to 2.3.1 #2148 is merged up from 4.6 to 5.0.
Related PRs:
Strictly speaking not related, but needed in order to make the invite user functionality work end-to-end (IBX-12340):
Description:
Ibexa\AdminUi\Notifier\UserInvitation::sendInvitation()andIbexa\AdminUi\Notifier\PasswordReset::sendMessage()both return without sending and without anytrace when
notifications.subscriptionsdoes not carry their notification class:Both classes are
LoggerAwareand are handed a logger, but nothing is logged if the notificationclass is not mentioned in
notifications.subscriptions.This PR turns the silent return into a logged warning, naming the exact configuration key to add.
For QA:
Ibexa\AdminUi\Notifier\Notification\UserInvitationfromibexa.system.<scope>.notifier.subscriptions, clear cache, and invite a user from the backoffice. The invitation row is still written to
ibexa_user_invitation; expect no mail, and invar/log/dev.log:app.WARNING: No invitation e-mail was sent: subscribe Ibexa\AdminUi\Notifier\Notification\UserInvitation under "ibexa.system.<scope>.notifier.subscriptions" to enable it.Ibexa\AdminUi\Notifier\Notification\UserPasswordReset.Documentation: