IBX-12187: Update form-label bottom margin to match labels design - #1991
Merged
Conversation
ibexa-workflow-automation-1
Bot
requested review from
GrabowskiM,
OstafinL,
albozek,
alekmick and
dew326
and removed request for
a team
August 4, 2026 10:26
dew326
approved these changes
Aug 4, 2026
tischsoic
force-pushed
the
IBX-12187-labels-design
branch
from
August 7, 2026 09:35
9d7e819 to
f1b763d
Compare
barbaragr
force-pushed
the
IBX-12067-new-fonts
branch
from
August 11, 2026 12:32
5395e0f to
b644392
Compare
tischsoic
force-pushed
the
IBX-12187-labels-design
branch
from
August 11, 2026 14:17
f1b763d to
165e05f
Compare
GrabowskiM
approved these changes
Aug 12, 2026
albozek
approved these changes
Aug 12, 2026
alekmick
approved these changes
Aug 12, 2026
tischsoic
force-pushed
the
IBX-12067-new-fonts
branch
from
August 13, 2026 10:40
b644392 to
d432d90
Compare
tischsoic
force-pushed
the
IBX-12187-labels-design
branch
from
August 13, 2026 10:42
165e05f to
73afc56
Compare
barbaragr
approved these changes
Aug 17, 2026
tischsoic
force-pushed
the
IBX-12187-labels-design
branch
from
August 18, 2026 08:27
73afc56 to
1d050bb
Compare
barbaragr
force-pushed
the
IBX-12187-labels-design
branch
from
August 18, 2026 08:37
1d050bb to
0839756
Compare
Contributor
Author
|
Claude: All CI green ✅ before removing dependencies.json |
tischsoic
force-pushed
the
IBX-12187-labels-design
branch
from
August 18, 2026 12:37
0839756 to
86f7936
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Browser tests here stay red until ibexa/design-system#125 merges (the CI-only
dependencies.jsonpin was removed for merge — CI was green with it, see comments). Delete theadmin-ui-assets#IBX-12187-labels-designbranch after merging.Related PRs:
Description:
Labels rendered with Bootstrap's
form-labelclass (e.g.<twig:ibexa:label class="form-label">across admin-ui, discounts, order-management, …) kept Bootstrap's defaultmargin-bottom: .5rem(7px at our 14px root), overriding the 4px label→input gap introduced in the design system (ibexa/design-system#125). Sets$form-label-margin-bottom: calculateRem(4px)in the Bootstrap config so all of them match the labels design.For QA:
/admin/payment-methodand/admin/discounts/create/catalog/fixed_amount?language_code=eng-GB: every label should sit 4px above its input (previously 7px onform-labelones).Documentation:
🤖 Generated with Claude Code