Remove LayoutViewFactory + refactor FeatureView to make it compose-first (first commit)#2
Open
iantybo wants to merge 1 commit into
Open
Remove LayoutViewFactory + refactor FeatureView to make it compose-first (first commit)#2iantybo wants to merge 1 commit into
iantybo wants to merge 1 commit into
Conversation
Owner
Author
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (35)
💤 Files with no reviewable changes (19)
📝 WalkthroughWalkthrough
ChangesCompose Rendering Migration
🚥 Pre-merge checks | ✅ 6 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of the first commit of instacart/formula#511 for CodeRabbit review.
Head is
4fc15c1(the first commit of PR #511) against the same base commit (f8f1aa3) the original ran against.Original PR: instacart/formula#511
Risk Score: High - Possible Team Escalation Required
Summary
This PR represents a major architectural refactoring that eliminates Android View-based abstractions and establishes Jetpack Compose as the primary rendering mechanism. The changes remove two key abstraction layers (
LayoutViewFactoryandViewInstance), refactor the coreFeatureViewcomponent to be Compose-centric, consolidateComposeViewFactoryfrom a separate module into the main library, and update all affected samples and tests accordingly.Key Changes
Core Architectural Refactoring:
FeatureViewsignature completely changed fromFeatureView<RenderModel>(val view: View, val setOutput: (RenderModel) -> Unit)toFeatureView<RenderModel>(val content:@composable(RenderModel) -> Unit, val initialModel: RenderModel? = null), making Compose rendering the primary contractLayoutViewFactoryandViewInstanceentirely, eliminating the XML layout inflation abstractionFormulaFragmentnow uses Jetpack Compose interop directly: createsComposeView, manages state viaMutableState, and composes viafeatureView.content(state)Module Consolidation:
ComposeViewFactoryfrom separateformula-android-composemodule intoformula-androidformula-android-composemodule and its build configurationViewFactory.fromLayout()static factory and simplifiedViewFactory.Paramsto accept onlycontext(removedLayoutInflaterandViewGroup)Sample Updates:
RenderView-based Android views to Jetpack Compose, replacingTaskListRenderViewwithTaskListScreencomposableComposeViewFactoryfrom the relocated moduleTest Infrastructure:
TestViewFactoryrefactored to work with ComposeFeatureViewinstead ofLayoutViewFactoryFormulaFragmentTestto verify render exceptions are no longer routed toenvironment#onScreenErrorViewFactoryTest,ViewInstanceTest)Impact
This is a breaking change that eliminates multiple public APIs and requires consumers to:
LayoutViewFactoryimplementations withComposeViewFactoryViewFactory.Paramsusage to only passcontextViewInstance-based patterns to use Compose-based renderingThe refactoring is systematic and well-coordinated, with all related modules, samples, and tests updated in a single PR. However, the magnitude of breaking changes requires coordination with dependent projects and careful migration planning.