Repository navigation
Disable/enable instrumentations #44
Description
Auto instrumentation can sometimes cause issues. Therefore having a config to disable a specific framework(s) is very useful.
I need this config for the Javaagent but I anticipate it might be useful for other agents as well. In java agent a framework instrumentation can be disabled by -Dotel.instrumentation.aws-sdk.enabled=false".
I propose to add top level config
message AgentConfig {
map<string, boolean> instrumentation = 3;
}
The boolean because in some cases an agent might ship instrumentation that is disabled by default (e.g. produces too much data) so there should be a way to enable it.
Reacted by José Carlos Chávez
Activity
[-]Disable instrumentation [/-][+]Disable/enable instrumentations[/+]davexroth commentedon Jan 29, 2021
+1
jcchavezs commentedon Jan 29, 2021
Question so the key in the map defines the framework?
pavolloffay commentedon Jan 29, 2021
yes e.g.
servletjcchavezs commentedon Jan 29, 2021
mohit-a21 commentedon Feb 1, 2021
@jcchavezs Can this be used by goagent for disabling tracing for specific packages? If this is specific to java agent and we would have to add different config for go agent, then I would prefer having this as a
oneof. @pavolloffayjcchavezs commentedon Feb 20, 2021
@mohit-a21 that would be the idea.