Add: expose device-wide HBM information - #2011
Open
ChaoZheng109 wants to merge 1 commit into
Open
Conversation
Add an aclrtGetMemInfo-backed Worker query for L2 and local L3 workers, with a structured and unpackable free/total result. Keep allocator committed-memory accounting as its separate existing API and report simulator support explicitly. Cover both runtimes and platforms in sim, validate logical worker routing and control ordering, and compare onboard results with the direct ACL query. Fixes hw-native-sys#1878
|
Warning Review limit reachedNext included review available in 37 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (17)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Worker.device_memory_info(worker_id=0)with a structured, unpackableDeviceMemoryInfoaclrtGetMemInfo(ACL_HBM_MEM)in the target chip worker while keepingcommitted_device_memory()separateTesting
pre-commit runFixes #1878