fix: pass prompt_file_suffix through ContextManager.__init__ - #355
Open
andrewwhitecdw wants to merge 1 commit into
Open
Conversation
ContextManager accepted a prompt_file_suffix argument but hardcoded 'system_prompt_v3.yaml' when calling _load_system_prompt, so callers could not select a different prompt template. Adds a unit test that patches _load_system_prompt and asserts the provided suffix is forwarded. Signed-off-by: Andrew White <andrewh@cdw.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
ContextManager.__init__accepted aprompt_file_suffixargument but hardcoded"system_prompt_v3.yaml"when calling_load_system_prompt, so callers could not select a different prompt template.Fix
Forward the provided
prompt_file_suffixto_load_system_prompt.Test
Added
tests/unit/test_context_manager.pywith a test that patches_load_system_promptand asserts the provided suffix is forwarded.Verification
uv run --extra dev pytest tests/unit/test_context_manager.py -vpasses.