fix: stream compose logs in post-job cleanup by Copilot · Pull Request #298 · hoverkraft-tech/compose-action

Copilot · 2026-08-07T09:16:16Z

Large docker compose logs output could crash the post-job hook before cleanup completed because log collection buffered the full command output in memory. As a result, docker compose down could be skipped when service logs were very large.

Post-job log collection
- Replace the docker-compose package logs() helper with a direct docker compose logs process spawn.
- Stream stdout/stderr chunks to the configured service logger instead of assembling a single in-memory string.
- Remove the extra full-output re-log in post-runner, since logs are now emitted incrementally.
Cleanup resilience
- Treat log collection failures as non-fatal in the post hook.
- Continue to docker compose down even when log collection exits non-zero, is terminated by signal, or cannot be spawned.
Failure reporting
- Return concise diagnostic messages for abnormal log-command termination without reintroducing output buffering.
- Handle edge cases where the child process cannot provide output streams.

const childProcess = spawn("docker", commandArgs, { cwd });

childProcess.stdout.on("data", (chunk) => {
  serviceLogger(chunk.toString());
});

childProcess.stderr.on("data", (chunk) => {
  serviceLogger(chunk.toString());
});

Fixes Issue with collecting docker compose logs output in post job cleanup #297

neilime

@copilot handle feedbacks

Copilot · 2026-08-16T09:51:38Z

@copilot handle feedbacks

Addressed in 6100198. I restored the explicit docker compose logs: debug message in post-runner without bringing back buffered log aggregation, updated the related test, and revalidated with lint, build, test:ci, package, review, and CodeQL.

github-actions · 2026-08-18T13:05:29Z

Super-linter summary

Language	Validation result
BIOME_FORMAT	Fail ❌
BIOME_LINT	Pass ✅
CHECKOV	Pass ✅
GITLEAKS	Pass ✅
GIT_COMMITLINT	Pass ✅
GIT_MERGE_CONFLICT_MARKERS	Pass ✅
JSCPD	Pass ✅
PRE_COMMIT	Pass ✅
SPELL_CODESPELL	Fail ❌
TRIVY	Pass ✅

Super-linter detected linting errors

For more information, see the GitHub Actions workflow run

Powered by Super-linter

BIOME_FORMAT

Checked 26 files in 179ms. No fixes applied.
Found 2 errors.src/services/docker-compose.service.test.ts format ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

  × Formatter would have printed the following content:

    381 381 │         const logsPromise = service.logs(logsInputs);
    382 382 │
    383     │ - ······expect(spawnMock).toHaveBeenCalledWith("docker",·[
    384     │ - ········"compose",
    385     │ - ········"-f",
    386     │ - ········"docker-compose.yml",
    387     │ - ········"logs",
    388     │ - ········"helloworld2",
    389     │ - ········"helloworld3",
    390     │ - ······],·{
    391     │ - ········cwd:·"/current/working/dir",
    392     │ - ······});
        383 │ + ······expect(spawnMock).toHaveBeenCalledWith(
        384 │ + ········"docker",
        385 │ + ········[
        386 │ + ··········"compose",
        387 │ + ··········"-f",
        388 │ + ··········"docker-compose.yml",
        389 │ + ··········"logs",
        390 │ + ··········"helloworld2",
        391 │ + ··········"helloworld3",
        392 │ + ········],
        393 │ + ········{
        394 │ + ··········cwd:·"/current/working/dir",
        395 │ + ········},
        396 │ + ······);
    393 397 │
    394 398 │         stdout.emit("data", Buffer.from("logs"));
    ······· │
    421 425 │         const logsPromise = service.logs(logsInputs);
    422 426 │
    423     │ - ······expect(spawnMock).toHaveBeenCalledWith("docker",·[
    424     │ - ········"--context",
    425     │ - ········"dev",
    426     │ - ········"compose",
    427     │ - ········"--profile",
    428     │ - ········"ci",
    429     │ - ········"-f",
    430     │ - ········"docker-compose.yml",
    431     │ - ········"logs",
    432     │ - ······],·{
    433     │ - ········cwd:·"/current/working/dir",
    434     │ - ······});
        427 │ + ······expect(spawnMock).toHaveBeenCalledWith(
        428 │ + ········"docker",
        429 │ + ········[
        430 │ + ··········"--context",
        431 │ + ··········"dev",
        432 │ + ··········"compose",
        433 │ + ··········"--profile",
        434 │ + ··········"ci",
        435 │ + ··········"-f",
        436 │ + ··········"docker-compose.yml",
        437 │ + ··········"logs",
        438 │ + ········],
        439 │ + ········{
        440 │ + ··········cwd:·"/current/working/dir",
        441 │ + ········},
        442 │ + ······);
    435 443 │
    436 444 │         childProcess.emit("close", 1);
    ······· │
    517 525 │
    518 526 │         await expect(service.logs(logsInputs)).resolves.toEqual({
    519     │ - ········error:·"Unable·to·collect·docker·compose·logs:·stdout/stderr·unavailable",
        527 │ + ········error:
        528 │ + ··········"Unable·to·collect·docker·compose·logs:·stdout/stderr·unavailable",
    520 529 │           output: "",
    521 530 │         });


src/services/docker-compose.service.ts format ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

  × Formatter would have printed the following content:

     86  86 │           settled = true;
     87  87 │           resolve({
     88     │ - ··········error:·"Unable·to·collect·docker·compose·logs:·stdout/stderr·unavailable",
         88 │ + ··········error:
         89 │ + ············"Unable·to·collect·docker·compose·logs:·stdout/stderr·unavailable",
     89  90 │             output: "",
     90  91 │           });
    ······· │
    104 105 │           settled = true;
    105 106 │           resolve({
    106     │ - ··········error:
    107     │ - ············signal
    108     │ - ··············?·`Docker·Compose·logs·command·failed·with·signal·${signal}`
    109     │ - ··············:·exitCode·!==·null·&&·exitCode·!==·0
    110     │ - ················?·`Docker·Compose·logs·command·failed·with·exit·code·${exitCode}`
    111     │ - ················:·"",
        107 │ + ··········error:·signal
        108 │ + ············?·`Docker·Compose·logs·command·failed·with·signal·${signal}`
        109 │ + ············:·exitCode·!==·null·&&·exitCode·!==·0
        110 │ + ··············?·`Docker·Compose·logs·command·failed·with·exit·code·${exitCode}`
        111 │ + ··············:·"",
    112 112 │             output: "",
    113 113 │           });


format ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

  × Some errors were emitted while running checks.

SPELL_CODESPELL

/github/workspace/dist/index.js:748: ECT ==> ETC
/github/workspace/dist/index.js:790: TE ==> THE, BE, WE, TO
/github/workspace/dist/index.js:12049: contructor ==> constructor
/github/workspace/dist/index.js:19691: addIn ==> adding, add in, add-on
/github/workspace/dist/index.js:19698: addIn ==> adding, add in, add-on
/github/workspace/dist/index.js:21152: alse ==> also, else, false
/github/workspace/dist/index.js:21625: alse ==> also, else, false
/github/workspace/dist/index.js:22267: addIn ==> adding, add in, add-on
/github/workspace/dist/index.js:22269: addIn ==> adding, add in, add-on
/github/workspace/dist/index.js:28705: fpr ==> for, far, fps
/github/workspace/dist/index.js:28712: fpr ==> for, far, fps
/github/workspace/dist/index.js:30336: boolen ==> boolean
/github/workspace/dist/index.js:30421: collapsable ==> collapsible
/github/workspace/dist/index.js:30424: collapsable ==> collapsible
/github/workspace/dist/post.js:748: ECT ==> ETC
/github/workspace/dist/post.js:790: TE ==> THE, BE, WE, TO
/github/workspace/dist/post.js:12049: contructor ==> constructor
/github/workspace/dist/post.js:19691: addIn ==> adding, add in, add-on
/github/workspace/dist/post.js:19698: addIn ==> adding, add in, add-on
/github/workspace/dist/post.js:21152: alse ==> also, else, false
/github/workspace/dist/post.js:21625: alse ==> also, else, false
/github/workspace/dist/post.js:22267: addIn ==> adding, add in, add-on
/github/workspace/dist/post.js:22269: addIn ==> adding, add in, add-on
/github/workspace/dist/post.js:26885: boolen ==> boolean
/github/workspace/dist/post.js:26970: collapsable ==> collapsible
/github/workspace/dist/post.js:26973: collapsable ==> collapsible

github-actions · 2026-08-18T13:16:25Z

Super-linter summary

Language	Validation result
BIOME_FORMAT	Pass ✅
BIOME_LINT	Pass ✅
CHECKOV	Pass ✅
GITLEAKS	Pass ✅
GIT_COMMITLINT	Pass ✅
GIT_MERGE_CONFLICT_MARKERS	Pass ✅
JSCPD	Pass ✅
PRE_COMMIT	Pass ✅
SPELL_CODESPELL	Pass ✅
TRIVY	Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

codecov · 2026-08-18T13:18:43Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (e56276d) to head (135b46f).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #298   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          173       179    +6     
  Branches        37        38    +1     
=========================================
+ Hits           173       179    +6

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: neilime <314088+neilime@users.noreply.github.com>

github-actions · 2026-08-18T13:40:53Z

Super-linter summary

Language	Validation result
BIOME_FORMAT	Pass ✅
BIOME_LINT	Pass ✅
CHECKOV	Pass ✅
GITLEAKS	Pass ✅
GIT_COMMITLINT	Pass ✅
GIT_MERGE_CONFLICT_MARKERS	Pass ✅
JSCPD	Pass ✅
PRE_COMMIT	Pass ✅
SPELL_CODESPELL	Pass ✅
TRIVY	Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

Co-authored-by: neilime <314088+neilime@users.noreply.github.com> Signed-off-by: Emilien Escalle <emilien.escalle@escemi.com>

github-actions · 2026-08-18T14:31:58Z

Super-linter summary

Language	Validation result
BIOME_FORMAT	Pass ✅
BIOME_LINT	Pass ✅
CHECKOV	Pass ✅
GITLEAKS	Pass ✅
GIT_COMMITLINT	Pass ✅
GIT_MERGE_CONFLICT_MARKERS	Pass ✅
JSCPD	Pass ✅
PRE_COMMIT	Pass ✅
SPELL_CODESPELL	Pass ✅
TRIVY	Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

neilime

@copilot handle feedbacks

Co-authored-by: neilime <314088+neilime@users.noreply.github.com>

Copilot · 2026-09-17T16:05:03Z

@copilot handle feedbacks

Addressed in 6d8e925. The custom log-spawn path was removed in favor of docker-compose v1.5.0 with maxOutputLength: 0, while keeping post-job log collection non-fatal and regenerating the packaged action output.

neilime

@copilot handle feedbacks

neilime · 2026-09-17T16:14:34Z

+        output: out,
+      };
+    } catch (error) {
+      return {
+        error: this.getDockerComposeErrorMessage(error),
+        output: "",


IMO, returning output is useless now

Co-authored-by: neilime <314088+neilime@users.noreply.github.com>

Copilot · 2026-09-17T16:18:24Z

@copilot handle feedbacks

Addressed in dd035d0. I removed the unused output value from the internal post-job logs API, updated the related tests, and revalidated with lint, build, test:ci, package, secret scanning, and parallel validation.

github-actions · 2026-09-17T16:24:51Z

Super-linter summary

Language	Validation result
BIOME_FORMAT	Pass ✅
BIOME_LINT	Pass ✅
CHECKOV	Pass ✅
GITLEAKS	Pass ✅
GIT_COMMITLINT	Pass ✅
GIT_MERGE_CONFLICT_MARKERS	Pass ✅
JSCPD	Pass ✅
PRE_COMMIT	Pass ✅
SPELL_CODESPELL	Pass ✅
TRIVY	Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

neilime

@copilot handle code coverage miss issue: #298 (comment)

Co-authored-by: neilime <314088+neilime@users.noreply.github.com>

Copilot · 2026-09-17T16:31:49Z

@copilot handle code coverage miss issue: #298 (comment)

Addressed in 135b46f. I added coverage for the non-Error log collection failure path in post-runner and revalidated with lint, build, test:ci, secret scanning, and parallel validation.

github-actions · 2026-09-17T16:37:02Z

Super-linter summary

Language	Validation result
BIOME_FORMAT	Pass ✅
BIOME_LINT	Pass ✅
CHECKOV	Pass ✅
GITLEAKS	Pass ✅
GIT_COMMITLINT	Pass ✅
GIT_MERGE_CONFLICT_MARKERS	Pass ✅
JSCPD	Pass ✅
PRE_COMMIT	Pass ✅
SPELL_CODESPELL	Pass ✅
TRIVY	Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

Copilot AI assigned Copilot and neilime Aug 7, 2026

Copilot started work on behalf of neilime August 7, 2026 09:16 View session

Copilot AI linked an issue Aug 7, 2026 that may be closed by this pull request

Issue with collecting docker compose logs output in post job cleanup #297

Closed

5 tasks

Copilot AI changed the title ~~[WIP] Fix issue with collecting docker compose logs output~~ fix: stream compose logs in post-job cleanup Aug 7, 2026

Copilot finished work on behalf of neilime August 7, 2026 09:28

Copilot AI requested a review from neilime August 7, 2026 09:28

neilime requested changes Aug 16, 2026

View reviewed changes

Copilot started work on behalf of neilime August 16, 2026 09:48 View session

Copilot finished work on behalf of neilime August 16, 2026 09:51

Copilot AI requested a review from neilime August 16, 2026 09:51

neilime force-pushed the copilot/fix-docker-compose-logs-issue branch from 6100198 to 6f7e04a Compare August 18, 2026 13:03

neilime force-pushed the main branch from 2796759 to 563b17f Compare August 18, 2026 13:04

neilime force-pushed the copilot/fix-docker-compose-logs-issue branch from 6f7e04a to 05978b5 Compare August 18, 2026 13:14

neilime force-pushed the main branch from 563b17f to e56276d Compare August 18, 2026 13:24

Copilot AI and others added 2 commits August 18, 2026 15:39

fix: stream compose logs during post cleanup

26f805a

Co-authored-by: neilime <314088+neilime@users.noreply.github.com>

fix: avoid buffering compose logs during cleanup

75b024b

Co-authored-by: neilime <314088+neilime@users.noreply.github.com>

neilime force-pushed the copilot/fix-docker-compose-logs-issue branch from 05978b5 to 5e62815 Compare August 18, 2026 13:39

fix: restore post-job compose logs header

6f330cd

Co-authored-by: neilime <314088+neilime@users.noreply.github.com> Signed-off-by: Emilien Escalle <emilien.escalle@escemi.com>

neilime force-pushed the copilot/fix-docker-compose-logs-issue branch from 5e62815 to 6f330cd Compare August 18, 2026 14:29

neilime requested changes Sep 17, 2026

View reviewed changes

Comment thread src/services/docker-compose.service.ts

Copilot started work on behalf of neilime September 17, 2026 15:59 View session

fix: use upstream compose log buffering

2bb782d

Co-authored-by: neilime <314088+neilime@users.noreply.github.com>

Copilot finished work on behalf of neilime September 17, 2026 16:05

Copilot AI requested a review from neilime September 17, 2026 16:05

neilime requested changes Sep 17, 2026

View reviewed changes

Copilot started work on behalf of neilime September 17, 2026 16:16 View session

refactor: drop unused compose logs output

dd035d0

Co-authored-by: neilime <314088+neilime@users.noreply.github.com>

Copilot finished work on behalf of neilime September 17, 2026 16:18

Copilot AI requested a review from neilime September 17, 2026 16:18

github-actions Bot added the type: fix Fixes a bug label Sep 17, 2026

neilime marked this pull request as ready for review September 17, 2026 16:26

neilime requested changes Sep 17, 2026

View reviewed changes

Copilot started work on behalf of neilime September 17, 2026 16:30 View session

test: cover post-runner log warning fallback

135b46f

Co-authored-by: neilime <314088+neilime@users.noreply.github.com>

Copilot finished work on behalf of neilime September 17, 2026 16:32

Copilot AI requested a review from neilime September 17, 2026 16:32

neilime approved these changes Sep 17, 2026

View reviewed changes

neilime merged commit b659c74 into main Sep 17, 2026
41 checks passed

neilime deleted the copilot/fix-docker-compose-logs-issue branch September 17, 2026 16:47

Conversation

Copilot AI commented Aug 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

neilime left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Aug 16, 2026

Uh oh!

github-actions Bot commented Aug 18, 2026

Super-linter summary

Uh oh!

github-actions Bot commented Aug 18, 2026

Super-linter summary

Uh oh!

codecov Bot commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented Aug 18, 2026

Super-linter summary

Uh oh!

github-actions Bot commented Aug 18, 2026

Super-linter summary

Uh oh!

neilime left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI commented Sep 17, 2026

Uh oh!

neilime left a comment

Choose a reason for hiding this comment

Uh oh!

neilime Sep 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Sep 17, 2026

Uh oh!

github-actions Bot commented Sep 17, 2026

Super-linter summary

Uh oh!

neilime left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Sep 17, 2026

Uh oh!

github-actions Bot commented Sep 17, 2026

Super-linter summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Aug 7, 2026 •

edited

Loading

codecov Bot commented Aug 18, 2026 •

edited

Loading