Skip to content

build(deps): patch trapframe dependency#2525

Open
mkroening wants to merge 2 commits into
mainfrom
patch-trapframe
Open

build(deps): patch trapframe dependency#2525
mkroening wants to merge 2 commits into
mainfrom
patch-trapframe

Conversation

@mkroening

@mkroening mkroening commented Jul 3, 2026

Copy link
Copy Markdown
Member

This PR patches the trapframe dependency to include rcore-os/trapframe-rs#18, which should fix the linker issues I saw in #2425 (CI only, very fragile).

In the long term, we should probably migrate away from this dependency (#2526).

@mkroening mkroening self-assigned this Jul 3, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Results

Details
Benchmark Current: beb33c0 Previous: 8b752b3 Performance Ratio
startup_benchmark Build Time 81.80 s 80.58 s 1.02
startup_benchmark File Size 0.80 MB 0.80 MB 1.00
Startup Time - 1 core 0.76 s (±0.02 s) 0.75 s (±0.02 s) 1.02
Startup Time - 2 cores 0.77 s (±0.02 s) 0.75 s (±0.02 s) 1.03
Startup Time - 4 cores 0.76 s (±0.02 s) 0.76 s (±0.03 s) 1.01
multithreaded_benchmark Build Time 83.23 s 83.77 s 0.99
multithreaded_benchmark File Size 0.90 MB 0.90 MB 1.00
Multithreaded Pi Efficiency - 2 Threads 88.16 % (±6.12 %) 88.91 % (±5.63 %) 0.99
Multithreaded Pi Efficiency - 4 Threads 43.41 % (±1.74 %) 43.58 % (±2.56 %) 1.00
Multithreaded Pi Efficiency - 8 Threads 25.40 % (±1.19 %) 25.21 % (±1.38 %) 1.01
micro_benchmarks Build Time 83.66 s 83.23 s 1.01
micro_benchmarks File Size 0.90 MB 0.90 MB 1.00
Scheduling time - 1 thread 65.57 ticks (±2.60 ticks) 66.41 ticks (±2.49 ticks) 0.99
Scheduling time - 2 threads 37.42 ticks (±5.28 ticks) 36.98 ticks (±4.38 ticks) 1.01
Micro - Time for syscall (getpid) 4.30 ticks (±0.66 ticks) 4.38 ticks (±0.61 ticks) 0.98
Memcpy speed - (built_in) block size 4096 80175.22 MByte/s (±55657.14 MByte/s) 80964.12 MByte/s (±56065.00 MByte/s) 0.99
Memcpy speed - (built_in) block size 1048576 30512.34 MByte/s (±24652.51 MByte/s) 30488.32 MByte/s (±24607.18 MByte/s) 1.00
Memcpy speed - (built_in) block size 16777216 26653.87 MByte/s (±22054.84 MByte/s) 26922.99 MByte/s (±22163.33 MByte/s) 0.99
Memset speed - (built_in) block size 4096 79591.37 MByte/s (±55295.03 MByte/s) 81292.09 MByte/s (±56295.77 MByte/s) 0.98
Memset speed - (built_in) block size 1048576 31202.21 MByte/s (±25047.67 MByte/s) 31212.89 MByte/s (±25032.24 MByte/s) 1.00
Memset speed - (built_in) block size 16777216 27310.70 MByte/s (±22426.14 MByte/s) 27704.28 MByte/s (±22658.95 MByte/s) 0.99
Memcpy speed - (rust) block size 4096 74571.55 MByte/s (±51877.51 MByte/s) 73359.02 MByte/s (±51215.91 MByte/s) 1.02
Memcpy speed - (rust) block size 1048576 30431.50 MByte/s (±24666.93 MByte/s) 30393.47 MByte/s (±24606.70 MByte/s) 1.00
Memcpy speed - (rust) block size 16777216 27364.41 MByte/s (±22595.17 MByte/s) 27849.43 MByte/s (±22986.75 MByte/s) 0.98
Memset speed - (rust) block size 4096 74755.15 MByte/s (±51998.38 MByte/s) 73359.02 MByte/s (±51215.91 MByte/s) 1.02
Memset speed - (rust) block size 1048576 31147.13 MByte/s (±25078.94 MByte/s) 31145.98 MByte/s (±25044.39 MByte/s) 1.00
Memset speed - (rust) block size 16777216 28123.55 MByte/s (±23056.70 MByte/s) 28625.01 MByte/s (±23459.41 MByte/s) 0.98
alloc_benchmarks Build Time 76.02 s 77.14 s 0.99
alloc_benchmarks File Size 0.88 MB 0.88 MB 1.00
Allocations - Allocation success 91.31 % 91.31 % 1
Allocations - Deallocation success 100.00 % 100.00 % 1
Allocations - Pre-fail Allocations 61.44 % 61.44 % 1
Allocations - Average Allocation time 5018.19 Ticks (±84.48 Ticks) 5021.61 Ticks (±76.52 Ticks) 1.00
Allocations - Average Allocation time (no fail) 5748.90 Ticks (±109.60 Ticks) 5797.34 Ticks (±78.21 Ticks) 0.99
Allocations - Average Deallocation time 1171.72 Ticks (±144.88 Ticks) 1468.37 Ticks (±182.04 Ticks) 0.80
mutex_benchmark Build Time 76.69 s 76.50 s 1.00
mutex_benchmark File Size 0.90 MB 0.90 MB 1.00
Mutex Stress Test Average Time per Iteration - 1 Threads 12.10 ns (±0.30 ns) 12.08 ns (±0.27 ns) 1.00
Mutex Stress Test Average Time per Iteration - 2 Threads 42.70 ns (±2.43 ns) 41.70 ns (±1.99 ns) 1.02

This comment was automatically generated by workflow using github-action-benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant