Repository navigation
fix: phpstan usage, rector and modules - #90
Merged
Merged
Conversation
- add phpstan.ignore.neon for error handling - include phpstan.modules.php for dynamic module loading - update paths in phpstan.neon to include database and routes - update dependency phpstan/extension-installer to ^1.4.3
- update filament/filament to ^4.2.0 - update filament/spatie-laravel-media-library-plugin to ^4.2.0 - update he4rt/badge to >=1 - update he4rt/message to >=1 - update he4rt/season to >=1 - update spatie/laravel-medialibrary to ^11.17.3
danielhe4rt
approved these changes
Nov 6, 2025
RichardGL11
pushed a commit
that referenced
this pull request
Nov 6, 2025
This pull request introduces several improvements focused on code quality, static analysis configuration, and type safety across multiple modules. The most significant changes include adding PHPStan configuration and error ignore files to several modules, refactoring the `Event` model to `EventModel` in the events module, and enhancing Eloquent model factories and relationships with proper type annotations. Additionally, new Makefile and Taskfile command aliases have been added for developer convenience. **Static Analysis Configuration:** * Added `phpstan.neon` and `phpstan.ignore.neon` files to the `authentication`, `badge`, `character`, and `events` modules, enabling PHPStan static analysis and specifying ignored errors for known issues. * Updated PHPStan configuration to include the `src/` path and reference the ignore files in each module. **Model Refactoring and Type Safety (Events Module):** * Renamed the `Event` model to `EventModel` throughout the events module, updating all relevant imports and relationships for consistency and clarity. * Enhanced Eloquent relationships in `EventModel` and `Talk` models with precise return type annotations, improving IDE support and static analysis. **Type Annotations in Factories (Badge, Character, Events Modules):** * Added generic type annotations to factory classes such as `BadgeFactory`, `PastSeasonFactory`, `EventFactory`, and `TalkFactory` to clarify the model each factory targets. **Model Relationship Type Annotations (Character Module):** * Added generic return type annotations to Eloquent relationships in `Character` and `Wallet` models for improved type safety and static analysis. **Developer Experience Improvements:** * Added convenient command aliases (`p`, `f`, `t`) for PHPStan, format, and test commands in the `Makefile` and `Taskfile.yml` to streamline common development workflows. * Updated the `route-list` Makefile command to use colored output with the `--ansi` flag for better readability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements focused on code quality, static analysis configuration, and type safety across multiple modules. The most significant changes include adding PHPStan configuration and error ignore files to several modules, refactoring the
Eventmodel toEventModelin the events module, and enhancing Eloquent model factories and relationships with proper type annotations. Additionally, new Makefile and Taskfile command aliases have been added for developer convenience.Static Analysis Configuration:
phpstan.neonandphpstan.ignore.neonfiles to theauthentication,badge,character, andeventsmodules, enabling PHPStan static analysis and specifying ignored errors for known issues.src/path and reference the ignore files in each module.Model Refactoring and Type Safety (Events Module):
Eventmodel toEventModelthroughout the events module, updating all relevant imports and relationships for consistency and clarity.EventModelandTalkmodels with precise return type annotations, improving IDE support and static analysis.Type Annotations in Factories (Badge, Character, Events Modules):
BadgeFactory,PastSeasonFactory,EventFactory, andTalkFactoryto clarify the model each factory targets.Model Relationship Type Annotations (Character Module):
CharacterandWalletmodels for improved type safety and static analysis.Developer Experience Improvements:
p,f,t) for PHPStan, format, and test commands in theMakefileandTaskfile.ymlto streamline common development workflows.route-listMakefile command to use colored output with the--ansiflag for better readability.