fix(hulypulse-client): close socket when ping gets no pong - #11053
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
The ping timeout was cleared and recreated on every 30 second tick, so the 5 minute deadline never fired. The handler also only closed sockets that were no longer open. Keep the deadline of the oldest unanswered ping and close the socket when it fires. Signed-off-by: Raphael Fakhri <153192858+RaphaelFakhri@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the ping timeout in
HulypulseClientso a socket that stops answering pings gets closed and reconnected.Refs #10946 (first item only: the
HulypulseClientping timeout).Problem
startPing()runs every 30 seconds. On each tick it cleared the previous ping timeout and created a new 5 minute one. Because the interval is shorter than the timeout, the timeout never fired. Even when it fired, the handler closed the socket only ifreadyStatewas notOPEN, so a dead but open socket was never closed and never reconnected.Change
pong. The existingonclosehandler then runs the normal reconnect path.client.test.tswith two tests that use fake timers and a fakeWebSocket:Testing
The first test fails on the parent commit and passes with the change. The second test passes in both cases.
The presence client in
plugins/presence-resourceshas the same pattern and is not changed here.