[bug]: New feature popups aren't maked as dismissed if closed using Esc #1186

what happened?

Stardance occasionally has popups that show when we release new features, e.g. sticky streaks. They can be dismissed with the Esc key, but that doesn't lead to the site recording them as dismissed. Therefore the same popup will be shown on the next page load.

We all know how annoying popups can get, so it's extra important that these get properly dismissed when they're dismissed!

what did you expect to happen?

If I press Esc to close the popup once, I won't be shown it again.

how do we make it happen?

1. open Stardance for the first time since Friday 28 August to see the "Sticky streaks are here!" popup
2. Press Esc to close it
3. Refresh the page

show us!

where were you?

https://stardance.hackclub.com/shop/items/287 on Zen Browser & Linux