Replace example redirect URL in oauth documentation#1477
Open
angrypig555 wants to merge 1 commit into
Open
Conversation
Replaced "orpheus.gg" with "example.com" in the oauth documentation as there is a non-hack club related website on that domain.
Contributor
Greptile SummaryThis PR replaces an active third-party domain in the OAuth documentation.
Confidence Score: 5/5This looks safe to merge. No blocking issues found in the changed documentation. The new URL is consistent with the guide's authorization and callback examples. No application behavior changed, so tests are not needed for this edit.
What T-Rex did
Important Files Changed
Reviews (1): Last reviewed commit: "Replace example redirect URL in oauth do..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced "orpheus.gg" with "example.com" in the oauth documentation as there is a non-hack club related website on that domain.
Summary of the problem
In the oauth documentation (docs/oauth/oauth-apps.md) on line 16 there is an example redirect url. This url has an active website on it and is not affiliated with hackclub. It also may be confused with an official hackclub / hackatime domain. Later on in the documentation, example.com is used and this change would make the link look more like an example that should not be used in real code. Leaving the old url there may also be free advertising for that site / company.
Describe your changes
Changed the url on line 16 from
orpheus.ggtoexample.com