Repository navigation
Skip the float locale test unless the decimal point is a comma - #122
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testFloatExpansionIsLocaleIndependentswitches to a comma-decimal locale and skips itself when none is available, but it tooksetlocale()not returningfalseas proof that it had one. With musl,setlocale()accepts any locale name and leaves the decimal point as., so the test ran there and passed without ever seeing a comma decimal point. It now also checks that the decimal point really is a comma and skips otherwise. The check sits inside thetryblock, because a skip can now happen after the locale has been changed, and the previous locale must still be restored.