Repository navigation
Drop PHP 7 support - #121
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guzzle URI Template 3.0 drops PHP 7, so the package now requires PHP
^8.0and no longer needssymfony/polyfill-php80: the functions it provided are native from PHP 8.0. CI, PHPStan and PHP-CS-Fixer move from 7.4 to 8.0, and the contributor guidelines name the new floor.The one PHP 7 code path goes with it. Before PHP 8.0 the float-to-string cast followed
LC_NUMERIC, so floats were converted through a helper that put the.back under a comma-decimal locale. From 8.0 the cast is locale-independent, which leaves the helper with nothing to do, so it is removed, and the comments and documentation that named the locale as a reason are corrected. Expansion output does not change. The locale test and the CI step that generates a comma-decimal locale stay, because the documentation still promises locale-independent output.Running PHP-CS-Fixer on PHP 8.0 would start adding a trailing comma to every multiline parameter list. That is switched off here, so that the code keeps its current shape and changes merged up from 2.x, where such a comma is a syntax error on PHP 7.4, do not fail the style check.
The version table gains a row for 3.0, and the changelog and upgrade guide gain their first 3.0 entries.