Add book creation and listing features#1628
Conversation
Add create_book and list_all_books features - Soorya A P
Add book app features, create and list books
Added create_book and list_all_books features - Jairaj R
Book Management Feature
Implemented Book Features with proper Git Workflow
Added Book App Features (Create Book & List Books)
Github_Enablement_Task
Github_Enablement_Task
Added book features (create & list books)
- Created add_books_feature directory - Added create_book.txt with feature description Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Shows all books created by the user as a list Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Books will be listed in ascending order - Improves book discovery for users Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Includes list_all_books feature with sorting capability - Combines with create_book feature from develop Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add book app with create and list features - Mithun Thomas
Greptile SummaryThis PR adds
|
| Filename | Overview |
|---|---|
| my_intro.txt | Another contributor's intro text is overwritten with a different person's name — unauthorized modification of a peer's file. |
| Akash_A_book_app/add_books_feature/create_book.txt | Deleted by this PR along with its lowercase counterpart — removes another contributor's submitted files. |
| list_all_books.txt | A duplicate line is appended to the shared file, repeating the line that already exists on line 2. |
| yourname_book_app/add_books_feature/create_book.txt | Files committed into the placeholder template directory instead of the author's own named directory. |
| aswika_grifith_book_app/add_books_feature/aswika_grifith_book_app/add_books_feature/list_all_books.txt | File placed at an incorrectly nested duplicate path; the app directory name is repeated in the tree. |
| keziah_mariam_raison_book_app/add_books_feature/create_book.txt | GNU nano editor title bar committed as the first line of the file, followed by many blank lines before the actual content. |
| Athira_create_book.txt | Empty file added at the repository root rather than inside the expected add_books_feature/ subdirectory. |
| gagana_parvathi_book_app/add_books_feature/create_book.txt | Author's own create_book.txt added correctly under their named directory with appropriate content. |
| gagana_parvathi_book_app/add_books_feature/list_all_books.txt | Author's own list_all_books.txt added correctly under their named directory with appropriate content. |
| shaheen_t_app/create_book.txt | File placed directly under the app root rather than inside add_books_feature/, inconsistent with expected directory structure. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[PR by gaganaparvathi09] --> B[gagana_parvathi_book_app/\nadd_books_feature/]
B --> C[create_book.txt ✅]
B --> D[list_all_books.txt ✅]
A --> E[Unintended Changes]
E --> F[my_intro.txt\nOverwrites ChrisNijo/Pranav ❌]
E --> G[Akash_A_book_app/ &\nakash_a_book_app/ deleted ❌]
E --> H[list_all_books.txt\nDuplicate line appended ❌]
E --> I[yourname_book_app/\nPlaceholder dir used ❌]
E --> J[Nested duplicate path\naswika_grifith_book_app ❌]
E --> K[keziah_mariam_raison_book_app/\nNano header in file ⚠️]
E --> L[Athira_create_book.txt\nEmpty file at root ⚠️]
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A[PR by gaganaparvathi09] --> B[gagana_parvathi_book_app/\nadd_books_feature/]
B --> C[create_book.txt ✅]
B --> D[list_all_books.txt ✅]
A --> E[Unintended Changes]
E --> F[my_intro.txt\nOverwrites ChrisNijo/Pranav ❌]
E --> G[Akash_A_book_app/ &\nakash_a_book_app/ deleted ❌]
E --> H[list_all_books.txt\nDuplicate line appended ❌]
E --> I[yourname_book_app/\nPlaceholder dir used ❌]
E --> J[Nested duplicate path\naswika_grifith_book_app ❌]
E --> K[keziah_mariam_raison_book_app/\nNano header in file ⚠️]
E --> L[Athira_create_book.txt\nEmpty file at root ⚠️]
Comments Outside Diff (1)
-
Akash_A_book_app/add_books_feature/create_book.txtDeletion of another contributor's files
Both
Akash_A_book_app/add_books_feature/create_book.txtandakash_a_book_app/add_books_feature/create_book.txtare being deleted by this PR. These files belong to a different contributor (Akash A) and should not be touched. Removing them would erase their submitted work from the repository.
Reviews (1): Last reviewed commit: "Merge branch 'feature' into develop" | Re-trigger Greptile
| @@ -1 +1 @@ | |||
| Hello from ChrisNijo | |||
| Hey there it's Pranav here aka Alien | |||
There was a problem hiding this comment.
Unauthorized modification of another contributor's file
my_intro.txt originally read "Hello from ChrisNijo" and this PR replaces it with "Hey there it's Pranav here aka Alien". This file belongs to a different contributor; this PR should only add or modify files within the author's own directory (gagana_parvathi_book_app/). Overwriting another person's intro file is an unintended side-effect that would permanently destroy their contribution.
| @@ -1,2 +1,3 @@ | |||
| This is the feature which shows the user all the books they’ve created as a list. | |||
| List all books will list all books in ascending order. | |||
| List all books will list all books in ascending order. | |||
There was a problem hiding this comment.
| @@ -0,0 +1 @@ | |||
| This is the feature for the author to add a new book. | |||
There was a problem hiding this comment.
Placeholder template directory committed
Files are being added inside yourname_book_app/, which is clearly a template placeholder directory. Contributors are expected to replace yourname with their actual name. These files should be in a properly named directory (e.g. gagana_parvathi_book_app/), not in the template folder.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| @@ -0,0 +1 @@ | |||
| List all books will list all books in ascending order. | |||
There was a problem hiding this comment.
Incorrectly nested duplicate path
This file is nested at aswika_grifith_book_app/add_books_feature/aswika_grifith_book_app/add_books_feature/list_all_books.txt — the full app path is duplicated in the directory tree. The correct location is aswika_grifith_book_app/add_books_feature/list_all_books.txt (which also exists in this PR). This creates an extraneous file at a wrong path that should be removed.
| @@ -0,0 +1 @@ | |||
|
|
|||
There was a problem hiding this comment.
| @@ -0,0 +1,15 @@ | |||
| GNU nano 8.5 create_book.txt | |||
There was a problem hiding this comment.
Nano editor header line committed
The first line of this file contains GNU nano 8.5 create_book.txt — the title bar/header of the GNU nano text editor — followed by many blank lines before the actual content. This is an artifact of copying the terminal screen output instead of just the file content. The file should start directly with the intended text.
Completed the GitHub Enablement Task.