Skip to content

Add book creation and listing features#1628

Open
gaganaparvathi09 wants to merge 179 commits into
gtech-mulearn:developfrom
gaganaparvathi09:develop
Open

Add book creation and listing features#1628
gaganaparvathi09 wants to merge 179 commits into
gtech-mulearn:developfrom
gaganaparvathi09:develop

Conversation

@gaganaparvathi09

Copy link
Copy Markdown

Completed the GitHub Enablement Task.

  • Added create_book feature
  • Added list_all_books feature
  • Merged feature into develop

Athira1903 and others added 30 commits April 2, 2025 14:49
Add create_book and list_all_books features - Soorya A P
Add book app features, create and list books
Added create_book and list_all_books features - Jairaj R
favas7907 and others added 28 commits March 3, 2026 14:53
Implemented Book Features with proper Git Workflow
Added Book App Features (Create Book & List Books)
Added book features (create & list books)
- Created add_books_feature directory
- Added create_book.txt with feature description

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Shows all books created by the user as a list

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Books will be listed in ascending order
- Improves book discovery for users

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Includes list_all_books feature with sorting capability
- Combines with create_book feature from develop

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add book app with create and list features - Mithun Thomas
@greptile-apps

greptile-apps Bot commented Jul 8, 2026

Copy link
Copy Markdown

Greptile Summary

This PR adds create_book and list_all_books text files for the author (gagana_parvathi_book_app/) as part of a GitHub enablement task, but it also inadvertently includes several changes that affect other contributors' work and violate the repository's directory conventions.

  • Unauthorized changes to other contributors' files: my_intro.txt (belonging to ChrisNijo/Pranav) is overwritten, and two files under Akash_A_book_app/ and akash_a_book_app/ are deleted entirely — both owned by a different contributor.
  • Structural issues in the PR: Files from many other contributors are bundled in, including a file committed under the placeholder yourname_book_app/ template, a wrongly nested duplicate path for aswika_grifith_book_app, an empty root-level Athira_create_book.txt, a duplicate line appended to the shared list_all_books.txt, and a keziah_mariam_raison_book_app/create_book.txt that starts with a GNU nano editor header line.

Confidence Score: 2/5

Not safe to merge — this PR overwrites another contributor's intro file and permanently deletes two files belonging to a different contributor.

The PR overwrites my_intro.txt (a file belonging to ChrisNijo/Pranav) and deletes both Akash_A_book_app/add_books_feature/create_book.txt and akash_a_book_app/add_books_feature/create_book.txt, erasing another contributor's work. Additional issues include a duplicate line in the shared list_all_books.txt, files committed under the placeholder yourname_book_app/ template directory, a wrongly nested path for one contributor's file, and a create_book.txt that starts with a GNU nano editor title bar.

my_intro.txt, Akash_A_book_app/add_books_feature/create_book.txt, akash_a_book_app/add_books_feature/create_book.txt, list_all_books.txt, yourname_book_app/add_books_feature/create_book.txt

Important Files Changed

Filename Overview
my_intro.txt Another contributor's intro text is overwritten with a different person's name — unauthorized modification of a peer's file.
Akash_A_book_app/add_books_feature/create_book.txt Deleted by this PR along with its lowercase counterpart — removes another contributor's submitted files.
list_all_books.txt A duplicate line is appended to the shared file, repeating the line that already exists on line 2.
yourname_book_app/add_books_feature/create_book.txt Files committed into the placeholder template directory instead of the author's own named directory.
aswika_grifith_book_app/add_books_feature/aswika_grifith_book_app/add_books_feature/list_all_books.txt File placed at an incorrectly nested duplicate path; the app directory name is repeated in the tree.
keziah_mariam_raison_book_app/add_books_feature/create_book.txt GNU nano editor title bar committed as the first line of the file, followed by many blank lines before the actual content.
Athira_create_book.txt Empty file added at the repository root rather than inside the expected add_books_feature/ subdirectory.
gagana_parvathi_book_app/add_books_feature/create_book.txt Author's own create_book.txt added correctly under their named directory with appropriate content.
gagana_parvathi_book_app/add_books_feature/list_all_books.txt Author's own list_all_books.txt added correctly under their named directory with appropriate content.
shaheen_t_app/create_book.txt File placed directly under the app root rather than inside add_books_feature/, inconsistent with expected directory structure.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[PR by gaganaparvathi09] --> B[gagana_parvathi_book_app/\nadd_books_feature/]
    B --> C[create_book.txt ✅]
    B --> D[list_all_books.txt ✅]

    A --> E[Unintended Changes]
    E --> F[my_intro.txt\nOverwrites ChrisNijo/Pranav ❌]
    E --> G[Akash_A_book_app/ &\nakash_a_book_app/ deleted ❌]
    E --> H[list_all_books.txt\nDuplicate line appended ❌]
    E --> I[yourname_book_app/\nPlaceholder dir used ❌]
    E --> J[Nested duplicate path\naswika_grifith_book_app ❌]
    E --> K[keziah_mariam_raison_book_app/\nNano header in file ⚠️]
    E --> L[Athira_create_book.txt\nEmpty file at root ⚠️]
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[PR by gaganaparvathi09] --> B[gagana_parvathi_book_app/\nadd_books_feature/]
    B --> C[create_book.txt ✅]
    B --> D[list_all_books.txt ✅]

    A --> E[Unintended Changes]
    E --> F[my_intro.txt\nOverwrites ChrisNijo/Pranav ❌]
    E --> G[Akash_A_book_app/ &\nakash_a_book_app/ deleted ❌]
    E --> H[list_all_books.txt\nDuplicate line appended ❌]
    E --> I[yourname_book_app/\nPlaceholder dir used ❌]
    E --> J[Nested duplicate path\naswika_grifith_book_app ❌]
    E --> K[keziah_mariam_raison_book_app/\nNano header in file ⚠️]
    E --> L[Athira_create_book.txt\nEmpty file at root ⚠️]
Loading

Comments Outside Diff (1)

  1. Akash_A_book_app/add_books_feature/create_book.txt

    P1 Deletion of another contributor's files

    Both Akash_A_book_app/add_books_feature/create_book.txt and akash_a_book_app/add_books_feature/create_book.txt are being deleted by this PR. These files belong to a different contributor (Akash A) and should not be touched. Removing them would erase their submitted work from the repository.

Reviews (1): Last reviewed commit: "Merge branch 'feature' into develop" | Re-trigger Greptile

Comment thread my_intro.txt
@@ -1 +1 @@
Hello from ChrisNijo
Hey there it's Pranav here aka Alien

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Unauthorized modification of another contributor's file

my_intro.txt originally read "Hello from ChrisNijo" and this PR replaces it with "Hey there it's Pranav here aka Alien". This file belongs to a different contributor; this PR should only add or modify files within the author's own directory (gagana_parvathi_book_app/). Overwriting another person's intro file is an unintended side-effect that would permanently destroy their contribution.

Comment thread list_all_books.txt
@@ -1,2 +1,3 @@
This is the feature which shows the user all the books they’ve created as a list.
List all books will list all books in ascending order.
List all books will list all books in ascending order.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Duplicate line added to shared file

The line "List all books will list all books in ascending order." already exists on line 2 of this shared file. This PR adds the identical line again, resulting in a duplicate. This looks like an accidental double-commit of the same content.

@@ -0,0 +1 @@
This is the feature for the author to add a new book.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Placeholder template directory committed

Files are being added inside yourname_book_app/, which is clearly a template placeholder directory. Contributors are expected to replace yourname with their actual name. These files should be in a properly named directory (e.g. gagana_parvathi_book_app/), not in the template folder.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@@ -0,0 +1 @@
List all books will list all books in ascending order.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Incorrectly nested duplicate path

This file is nested at aswika_grifith_book_app/add_books_feature/aswika_grifith_book_app/add_books_feature/list_all_books.txt — the full app path is duplicated in the directory tree. The correct location is aswika_grifith_book_app/add_books_feature/list_all_books.txt (which also exists in this PR). This creates an extraneous file at a wrong path that should be removed.

Comment thread Athira_create_book.txt
@@ -0,0 +1 @@

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Empty file at wrong location

Athira_create_book.txt is placed at the repository root rather than inside a proper athira_*_book_app/add_books_feature/ directory, and its content is entirely empty (just a newline). This file does not follow the expected directory structure of the project.

@@ -0,0 +1,15 @@
GNU nano 8.5 create_book.txt

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Nano editor header line committed

The first line of this file contains GNU nano 8.5 create_book.txt — the title bar/header of the GNU nano text editor — followed by many blank lines before the actual content. This is an artifact of copying the terminal screen output instead of just the file content. The file should start directly with the intended text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.