Skip to content

docs(env): document the custom-app disk admission knobs - #150

Merged
omarsy merged 1 commit into
mainfrom
docs/image-admission-env
Oct 26, 2026
Merged

omarsy merged 1 commit into
mainfrom
docs/image-admission-env

Conversation

@omarsy

@omarsy omarsy commented Oct 26, 2026

Copy link
Copy Markdown
Member

env.env is the documented full set of operator vars (README points here), but the HLD §9 admission knobs from #148 never landed in it. Documents GREFFER_IMAGE_MAX_BYTES (20g default), GREFFER_IMAGE_MIN_FREE_BYTES (2g), GREFFER_IMAGE_COUNT_MAX (0=OFF with the catalog-charging rationale). One-file docs PR.

The README points operators at env.env as the full set; the HLD §9
admission knobs (GREFFER_IMAGE_MAX_BYTES / MIN_FREE_BYTES / COUNT_MAX)
shipped undocumented — including the count cap's deliberate
default-OFF and why.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-26T13:26:31.026461Z 6cd0251 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@omarsy
omarsy merged commit 5428363 into main Oct 26, 2026
1 check failed
@omarsy
omarsy deleted the docs/image-admission-env branch October 26, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant