Repository navigation
Refactor: axum based API migration - #2339
Merged
Merged
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. OpenSSF Scorecard
Scanned Files
|
tsurai
force-pushed
the
axum-migration
branch
7 times, most recently
from
August 13, 2026 13:35
a65a12a to
0b3fff9
Compare
tsurai
force-pushed
the
axum-migration
branch
11 times, most recently
from
August 24, 2026 10:58
569d882 to
a923185
Compare
tsurai
force-pushed
the
axum-migration
branch
2 times, most recently
from
August 26, 2026 06:34
1969d60 to
3cd2f6c
Compare
tsurai
marked this pull request as ready for review
August 26, 2026 07:27
tsurai
force-pushed
the
axum-migration
branch
2 times, most recently
from
August 31, 2026 13:57
415005e to
3871be7
Compare
tehforsch
requested changes
Sep 2, 2026
tehforsch
left a comment
Contributor
There was a problem hiding this comment.
Looks great! Thank you!
I have some initial comments just from looking at the code. I'll also look at the larger structure a little bit now, but if anything comes up I'll do it in a second review
tehforsch
requested changes
Sep 2, 2026
tsurai
force-pushed
the
axum-migration
branch
2 times, most recently
from
September 15, 2026 11:31
46e2a6d to
be7cb3e
Compare
tsurai
force-pushed
the
axum-migration
branch
2 times, most recently
from
September 25, 2026 08:10
7af7250 to
139742e
Compare
tsurai
added this pull request to stack #2386
October 2, 2026 12:11
ArnoStiefvater
self-requested a review
October 6, 2026 12:21
ArnoStiefvater
dismissed
their stale review
October 6, 2026 12:22
Dismissed review because it was just a blocker review.
tehforsch
previously approved these changes
Oct 6, 2026
tehforsch
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the old HTTP API with one based on axum for better maintainability. While this does require rather major refactoring within
openvasdthe changes are kept minimal to keep the PR scope reviewable. This leads to some awkward code that will be refactored in follow up PRs.Behavioral changes
JSONencoded payload MUST setContent-Type: application/json.HEADroutes are now RFC compliant, meaning they do the same as theirGETcounterpart but with the result body removed./are considered a separate route now, resulting in 404s.enable-get-scansoption under[endpoints]was previously ignored, defaulting to true. It's working properly now and defaults to false as documented.Jira: SC-1610