Fix masking permission errors during file locking - #369
Merged
Conversation
Don't hide permission errors on other files while holding a lock on a lock file. Before the "normal" permission errors where interpreted as permission errors on the lock file itself and therefore converted to a FileLockingError. With this change only the PermissionError on the lock file itself is a FileLockingError and other PermissionErrors are raised to the user of flock_wait instead. Closes #364
greenbonebot
enabled auto-merge (rebase)
August 10, 2026 13:46
Conventional Commits Report😢 No conventional commits found. 👉 Learn more about the conventional commits usage at Greenbone. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #369 +/- ##
==========================================
- Coverage 99.36% 98.94% -0.42%
==========================================
Files 7 7
Lines 470 475 +5
==========================================
+ Hits 467 470 +3
- Misses 3 5 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
bjoernricks
added
the
patch release
wiegandm
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix masking permission errors during file locking
Why
Don't hide permission errors on other files while holding a lock on a lock file. Before the "normal" permission errors where interpreted as permission errors on the lock file itself and therefore converted to a FileLockingError. With this change only the PermissionError on the lock file itself is a FileLockingError and other PermissionErrors are raised to the user of flock_wait instead.
References
Closes #364
Checklist