Repository navigation
Update Oxlint and handle its new diagnostics - #4687
Merged
trevor-scheer merged 6 commits intoNov 1, 2026
Merged
Conversation
|
trevor-scheer
marked this pull request as ready for review
November 1, 2026 20:35
trevor-scheer
merged commit Nov 1, 2026
483a582
into
trevor/dependency-updates-integration
14 checks passed
trevor-scheer
added a commit
that referenced
this pull request
Nov 1, 2026
The CodeMirror build helper pulls in an unused test/server toolchain, including Mocha's vulnerable serialization dependency. Its current major release still retains that chain. Replace it with a small invocation of the underlying `@marijn/buildtool`, preserving grammar generation, pure annotations, build/prepack commands, and published CJS/ESM/declaration paths. The replacement exposes the same 19 runtime exports. It also emits `index.d.cts`; package export-map behavior is otherwise unchanged. The existing NodeNext CodeMirror type-identity issue reproduces with either builder and isn't changed here. Stacked on #4687.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Oxlint 1.90 adds diagnostics that the old pinned version doesn't report. Update the linter and ESLint plugin with caret ranges, along with the matching type-aware checker. Fix the mechanical findings, move test readiness reporting into an effect, and remove redundant loading state from the Monaco example.
The new state-in-effect rule stays enabled. The editor/store synchronization paths retain their behavior with line-specific exceptions explaining each external synchronization; changing that state model would be a separate refactor.
Stacked on #4686.