Skip to content

CNN PR [3/4]: Add LCSC CNN model - #895

Merged
sevmag merged 1 commit into
graphnet-team:mainfrom
sevmag:features/cnn-lcsc
Nov 8, 2026
Merged

sevmag merged 1 commit into
graphnet-team:mainfrom
sevmag:features/cnn-lcsc

Conversation

@sevmag

@sevmag sevmag commented May 27, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fourth in the series of PRs being carved out of #813 (see the split tracking comment). Adds the LCSC convolutional backbone, building on the CNN base class from #894.

What's new

  • LCSC — convolutional model subclassing CNN (src/graphnet/models/cnn/lcsc.py).
  • Registers LCSC in cnn/__init__.py alongside CNN and IceCubeDNN.

⚠️ Stacked on #894 — draft until that merges

This branch is stacked on top of #894 (CNN base + IceCubeDNN). Because the base branch only exists in the fork, this PR targets main directly, so its current diff includes #894's files (cnn.py, icecube_dnn.py) as well as the net-new lcsc.py. Once #894 is merged into main, GitHub will automatically narrow this diff to just lcsc.py + the one-line __init__.py change.

Review/merge order: review #894 first; this PR is kept as a draft until #894 lands, then it'll be marked ready.

Test plan

Split from #813.

🤖 Generated with Claude Code

@sevmag sevmag mentioned this pull request May 27, 2026
@sevmag sevmag changed the title Add LCSC CNN model CNN PR [2/4]: Add LCSC CNN model May 27, 2026
@sevmag sevmag changed the title CNN PR [2/4]: Add LCSC CNN model CNN PR [3/4]: Add LCSC CNN model May 27, 2026
@sevmag sevmag changed the title CNN PR [3/4]: Add LCSC CNN model CNN PR [3/4]: Add CNN models May 27, 2026
@sevmag sevmag changed the title CNN PR [3/4]: Add CNN models CNN PR [3/4]: Add LCSC CNN model May 27, 2026
@sevmag sevmag mentioned this pull request May 27, 2026
3 of 5 tasks
@sevmag
sevmag force-pushed the features/cnn-lcsc branch 2 times, most recently from 6595b27 to ee562fa Compare September 12, 2026 16:19
@sevmag
sevmag marked this pull request as ready for review September 12, 2026 18:41

@Aske-Rosted Aske-Rosted left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go.

Add the LCSC convolutional backbone, building on the `CNN` base class.
Registered in `cnn/__init__.py` alongside `CNN` and `IceCubeDNN`.

Stacked on the CNN-base PR. Split from graphnet-team#813.
@sevmag
sevmag force-pushed the features/cnn-lcsc branch from ee562fa to c9e3765 Compare November 7, 2026 17:23
@sevmag
sevmag merged commit 262fb07 into graphnet-team:main Nov 8, 2026
12 checks passed
@sevmag
sevmag deleted the features/cnn-lcsc branch November 9, 2026 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants