Repository navigation
Update to 26.3 - #168
Update to 26.3#168
Conversation
|
|
|
Hello |
@granny From some testing, this PR jar is erroring without some more changes needed from BlueMap's upstream BlockStateDeserializer.java, notably: public BlockState read(NBTReader reader) throws IOException {
+ if (reader.peek() == TagType.STRING)
+ return new BlockState(Key.parse(reader.nextString()));
...
- case "Name" -> id = reader.nextString();
- case "Properties" -> {
+ case "id", "Name", "" -> id = reader.nextString();
+ case "properties", "Properties" -> {something minimal like this is enough to get Pl3xMap 26.3 working: + import de.bluecolored.bluenbt.TagType;
...
public BlockState read(NBTReader reader) throws IOException {
+ if (reader.peek() == TagType.STRING) {
+ return new BlockState(Pl3xMap.api().getBlockRegistry().get(reader.nextString()));
...
- case "Name" -> id = reader.nextString();
- case "Properties" -> {
+ case "id", "Name", "" -> id = reader.nextString();
+ case "properties", "Properties" -> {
}though you may ofc wish to absorb some other changes BlueMap also made for default blockstates in BlueMap-Minecraft/BlueMap@76ba188 |
|
Hey! Here's the full log in case you need it: |
|
heh can u update desc to say fixes #169 |
|
one of my friends appears to have submitted a PR and tested it on a new paper jar , four line fix |
Long-term fix would be to cache the default blockstates and use the values from that
Long-term fix would be to cache the default blockstates and use the values from that
Currently compiles. Haven't fully tested to see if it works properly. Some features may or may not throw errors, run at your own risk.
Download the pl3xmap jar for this pull request: pl3xmap-168.zip