Skip to content

Update to 26.3 - #168

Merged
granny merged 15 commits into
v3from
chore/26.3
Oct 14, 2026
Merged

granny merged 15 commits into
v3from
chore/26.3

Conversation

@granny

@granny granny commented Sep 22, 2026 •

Copy link
Copy Markdown
Owner

Currently compiles. Haven't fully tested to see if it works properly. Some features may or may not throw errors, run at your own risk.

  • add missing blocks
  • test for issues

Download the pl3xmap jar for this pull request: pl3xmap-168.zip

@granny granny added enhancement New feature or request build-pr-jar Enables a workflow to build Pl3xMap jars on the pull request. labels Sep 22, 2026
@benct

benct commented Sep 24, 2026 •

Copy link
Copy Markdown

Pl3xMap-26.3-SNAPSHOT.jar tested on a 26.3 vanilla fabric server, rendering failed with the following errors:
pl3xmap-errors.log

@Dalarwin

Copy link
Copy Markdown

Hello
latest.log
got some errors too

@DaMarine

DaMarine commented Sep 30, 2026 •

Copy link
Copy Markdown

Download the pl3xmap jar for this pull request: pl3xmap-168.zip

@granny From some testing, this PR jar is erroring without some more changes needed from BlueMap's upstream BlockStateDeserializer.java‎, notably:

    public BlockState read(NBTReader reader) throws IOException {
+        if (reader.peek() == TagType.STRING)
+            return new BlockState(Key.parse(reader.nextString()));
               ...
-                case "Name" -> id = reader.nextString();
-                case "Properties" -> {              
+                case "id", "Name", "" -> id = reader.nextString();
+                case "properties", "Properties" -> {

something minimal like this is enough to get Pl3xMap 26.3 working:

+  import de.bluecolored.bluenbt.TagType;
    ...
    public BlockState read(NBTReader reader) throws IOException {
+        if (reader.peek() == TagType.STRING) {
+            return new BlockState(Pl3xMap.api().getBlockRegistry().get(reader.nextString()));
               ...
-                case "Name" -> id = reader.nextString();
-                case "Properties" -> {              
+                case "id", "Name", "" -> id = reader.nextString();
+                case "properties", "Properties" -> {
        }

though you may ofc wish to absorb some other changes BlueMap also made for default blockstates in BlueMap-Minecraft/BlueMap@76ba188

@JimberryDev

Copy link
Copy Markdown

Hey!
I got some errors too.
I got

[11:46:05] [Pl3xMap-Renderer-1/INFO]: [MinecraftServer] System chat: [Pl3xMap] [ERROR] Failed to scan world minecraft:overworld at region Point[x=3, z=0]
[11:46:05] [Pl3xMap-Renderer-1/INFO]: [LoggedPrintStream] [STDERR]: java.lang.ArrayIndexOutOfBoundsException: Index -1 out of bounds for length 16
[11:46:05] [Pl3xMap-Renderer-1/INFO]: [LoggedPrintStream] [STDERR]: 	at knot//net.minecraft.world.level.block.RedstoneWireBlock.getColorForPower(RedstoneWireBlock.java:389)
[11:46:05] [Pl3xMap-Renderer-1/INFO]: [LoggedPrintStream] [STDERR]: 	at knot//net.pl3x.map.fabric.server.Pl3xMapFabricServer.getColorForPower(Pl3xMapFabricServer.java:226)
[11:46:05] [Pl3xMap-Renderer-1/INFO]: [LoggedPrintStream] [STDERR]: 	at knot//net.pl3x.map.core.util.Colors.fixBlockColor(Colors.java:300)
[11:46:05] [Pl3xMap-Renderer-1/INFO]: [LoggedPrintStream] [STDERR]: 	at knot//net.pl3x.map.core.renderer.VintageStoryRenderer.scanData(VintageStoryRenderer.java:92)
[11:46:05] [Pl3xMap-Renderer-1/INFO]: [LoggedPrintStream] [STDERR]: 	at knot//net.pl3x.map.core.renderer.task.RegionScanTask.scanRegion(RegionScanTask.java:120)
[11:46:05] [Pl3xMap-Renderer-1/INFO]: [LoggedPrintStream] [STDERR]: 	at knot//net.pl3x.map.core.renderer.task.RegionScanTask.run(RegionScanTask.java:90)
[11:46:05] [Pl3xMap-Renderer-1/INFO]: [LoggedPrintStream] [STDERR]: 	at java.base/java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1825)
[11:46:05] [Pl3xMap-Renderer-1/INFO]: [LoggedPrintStream] [STDERR]: 	at java.base/java.util.concurrent.CompletableFuture$AsyncRun.exec(CompletableFuture.java:1817)
[11:46:05] [Pl3xMap-Renderer-1/INFO]: [LoggedPrintStream] [STDERR]: 	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:511)
[11:46:05] [Pl3xMap-Renderer-1/INFO]: [LoggedPrintStream] [STDERR]: 	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1450)
[11:46:05] [Pl3xMap-Renderer-1/INFO]: [LoggedPrintStream] [STDERR]: 	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:2019)
[11:46:05] [Pl3xMap-Renderer-1/INFO]: [LoggedPrintStream] [STDERR]: 	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:187)
[11:46:05] [Pl3xMap-Renderer-0/INFO]: [MinecraftServer] System chat: [Pl3xMap] [ERROR] Failed to scan world minecraft:overworld at region Point[x=3, z=1]
[11:46:05] [Pl3xMap-Renderer-0/INFO]: [LoggedPrintStream] [STDERR]: java.lang.ArrayIndexOutOfBoundsException

Here's the full log in case you need it:
2026-10-06-4.log

@DereC4

DereC4 commented Oct 8, 2026

Copy link
Copy Markdown

heh can u update desc to say

fixes #169

@DereC4

DereC4 commented Oct 12, 2026

Copy link
Copy Markdown

one of my friends appears to have submitted a PR and tested it on a new paper jar , four line fix

Long-term fix would be to cache the default blockstates and use the values from that
@xu-shawn

Copy link
Copy Markdown
Contributor

@granny there's another instance of this bug with age. default crop blocks get assigned the wrong colors since now getAge() can also return -1. I opened #172 for the fix

@granny
granny merged commit 9876e4b into v3 Oct 14, 2026
4 checks passed
@granny
granny deleted the chore/26.3 branch October 14, 2026 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build-pr-jar Enables a workflow to build Pl3xMap jars on the pull request. enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants