Repository navigation
Keep template-only bits out of synced repos - #13
Merged
Merged
Conversation
- Guard ci.yml's conventions test step so it only runs in the template repo, and make verify-repository enforce that guard. - Drop the conventions/ paths from renovate.json; the generic build.gradle and gradle.properties patterns already cover conventions/ in the template. - Commit gradlew.bat with CRLF line endings and mark it -text so the sync stops converting it to LF.
gh pr merge --auto merges immediately when a repository has no required checks, so a failing change landed before CI ran. Wait for the pull request's checks instead and leave it open if they fail, time out or are absent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes found while reviewing the first sync PR to gpc/grails-export (gpc/grails-export#61).
Changes
ci.yml: theTest convention pluginsstep only runs in the template repo. Synced repos no longer haveconventions/, so the step failed there.verify-repository.groovynow fails if aci.ymlbuild step runs againstconventions/without that guard.renovate.json: drop theconventions/...paths. The genericbuild.gradle/gradle.propertiespatterns already matchconventions/build.gradleandconventions/gradle.properties, and the precompiled scripts carry no dependency coordinates.gradlew.bat: commit it with CRLF line endings and add a.gitattributesentry (gradlew.bat -text) so the sync no longer rewrites it to LF in target repos.Test plan
groovy .github/scripts/verify-repository.groovypassesgit ls-files --eol gradlew.batshowsi/crlf w/crlf attr/-textgradlew.bat