Repository navigation
test: protect class name compatibility - #3021
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed for #3015 can break existing consumers by widening public class name outputs to
string | undefinedor by restoring default classes when an override explicitly suppliesundefined. These regression checks preserve the current contracts before changing the input prop type.What Changed
getDefaultClassNames().rootanduseDayPicker().classNames.rootremain assignable tostring.classNames={{ root: undefined }}removes the default root class.Validation: both affected Jest suites pass (58 tests), workspace typechecking passes, and Biome passes for the changed files. Mutation checks confirm the new component test rejects filtering out undefined overrides, and the new type assertions reject widening
ClassNamesvalues tostring | undefined.