Skip to content

test: protect class name compatibility - #3021

Merged
gpbl merged 1 commit into
mainfrom
test/classnames-compatibility
Sep 30, 2026
Merged

gpbl merged 1 commit into
mainfrom
test/classnames-compatibility

Conversation

@gpbl

@gpbl gpbl commented Sep 30, 2026

Copy link
Copy Markdown
Owner

Changes proposed for #3015 can break existing consumers by widening public class name outputs to string | undefined or by restoring default classes when an override explicitly supplies undefined. These regression checks preserve the current contracts before changing the input prop type.

What Changed

Validation: both affected Jest suites pass (58 tests), workspace typechecking passes, and Biome passes for the changed files. Mutation checks confirm the new component test rejects filtering out undefined overrides, and the new type assertions reject widening ClassNames values to string | undefined.

@changeset-bot

changeset-bot Bot commented Sep 30, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 638fe0f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gpbl
gpbl marked this pull request as ready for review September 30, 2026 07:06
@gpbl
gpbl merged commit 54d489e into main Sep 30, 2026
11 checks passed
@gpbl
gpbl deleted the test/classnames-compatibility branch September 30, 2026 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Types: allow undefined in ClassNames values (classNames breaks under exactOptionalPropertyTypes)

1 participant