Skip to content

ci: use larger VMs for some builds - #6381

Merged
coryan merged 2 commits into
googleapis:mainfrom
coryan:ci-create-pool-with-larger-vms
Aug 13, 2026
Merged

ci: use larger VMs for some builds#6381
coryan merged 2 commits into
googleapis:mainfrom
coryan:ci-create-pool-with-larger-vms

Conversation

@coryan

@coryan coryan commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

The builds were too slow on e2-standard-8 (over 20m), using e2-standard-32 gets the builds to under 15m. We may still want to move some builds to post-PR.

The builds were too slow on `e2-standard-8` (over 20m), using
`e2-standard-32` gets the builds to under 15m. We may still want to move
some builds to post-PR.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request configures a new large worker pool (rust-sdk-pool-large) for resource-intensive Cloud Build triggers. The reviewer recommends configuring the worker_pool attribute directly on the google_cloudbuild_trigger resources rather than passing it as a custom substitution (_POOL_ID), which keeps the build YAML files generic and environment-agnostic.

Comment thread .gcb/builds/triggers/main.tf Outdated
Comment thread .gcb/builds/triggers/main.tf Outdated
@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.18%. Comparing base (fab0dfa) to head (88f5628).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6381      +/-   ##
==========================================
- Coverage   96.18%   96.18%   -0.01%     
==========================================
  Files         288      288              
  Lines       75394    75394              
==========================================
- Hits        72521    72517       -4     
- Misses       2873     2877       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coryan
coryan marked this pull request as ready for review August 13, 2026 21:26
@coryan
coryan requested a review from a team as a code owner August 13, 2026 21:26
@coryan
coryan merged commit 207064f into googleapis:main Aug 13, 2026
41 checks passed
@coryan
coryan deleted the ci-create-pool-with-larger-vms branch August 13, 2026 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants