Skip to content

docs(bigquery): improve RowIterator related docs - #6320

Open
alvarowolfx wants to merge 3 commits into
googleapis:mainfrom
alvarowolfx:docs-bq-row-streaming
Open

docs(bigquery): improve RowIterator related docs#6320
alvarowolfx wants to merge 3 commits into
googleapis:mainfrom
alvarowolfx:docs-bq-row-streaming

Conversation

@alvarowolfx

Copy link
Copy Markdown
Contributor

Towards #5844

@product-auto-label product-auto-label Bot added the api: bigquery Issues related to the BigQuery API. label Aug 10, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request significantly improves the documentation of the BigQuery query module by adding detailed descriptions and usage examples for the FromSql trait, as well as the Interval, Range, RowIterator, and Row structs. The review feedback correctly identifies several instances where private module paths (such as crate::query::CompleteQuery, crate::query::Row, and crate::query::RowIterator) are referenced in public documentation. These unresolved intra-doc links will trigger rustdoc::private_intra_doc_links warnings and fail CI builds, so they should be updated to use their public re-exported paths.

Comment thread src/bigquery/src/query/iterator.rs Outdated
Comment thread src/bigquery/src/query/iterator.rs Outdated
Comment thread src/bigquery/src/query/row.rs Outdated
@codecov

codecov Bot commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.26%. Comparing base (4ff2683) to head (3e33c3d).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6320   +/-   ##
=======================================
  Coverage   96.26%   96.26%           
=======================================
  Files         282      282           
  Lines       73304    73304           
=======================================
+ Hits        70563    70567    +4     
+ Misses       2741     2737    -4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alvarowolfx
alvarowolfx marked this pull request as ready for review August 10, 2026 20:26
@alvarowolfx
alvarowolfx requested a review from a team as a code owner August 10, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the BigQuery API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants