Skip to content

docs(bigquery): improve Query handles docs - #6212

Merged
alvarowolfx merged 10 commits into
googleapis:mainfrom
alvarowolfx:docs-bq-query-handles
Aug 12, 2026
Merged

docs(bigquery): improve Query handles docs#6212
alvarowolfx merged 10 commits into
googleapis:mainfrom
alvarowolfx:docs-bq-query-handles

Conversation

@alvarowolfx

Copy link
Copy Markdown
Contributor

Towards #5844

@product-auto-label product-auto-label Bot added the api: bigquery Issues related to the BigQuery API. label Jul 29, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds comprehensive documentation and usage examples to the Query, CompleteQuery, and RunQuery structs in the BigQuery query module. The feedback points out incorrect import paths for QueryReference in the newly added documentation and examples, which would cause broken intra-doc links and rustdoc warnings.

Comment thread src/bigquery/src/query/query_handle.rs Outdated
Comment thread src/bigquery/src/query/query_handle.rs Outdated
@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.26%. Comparing base (4ff2683) to head (1de1692).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6212   +/-   ##
=======================================
  Coverage   96.26%   96.26%           
=======================================
  Files         282      282           
  Lines       73304    73304           
=======================================
+ Hits        70563    70567    +4     
+ Misses       2741     2737    -4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alvarowolfx

Copy link
Copy Markdown
Contributor Author

/gemini review

@alvarowolfx
alvarowolfx marked this pull request as ready for review August 10, 2026 19:39
@alvarowolfx
alvarowolfx requested a review from a team as a code owner August 10, 2026 19:39

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request significantly improves the documentation for the BigQuery query execution API by adding comprehensive doc comments, usage examples, and error explanations for the Query, CompleteQuery, and RunQuery structs and their associated methods. I have no feedback to provide as there are no review comments.

@alvarowolfx
alvarowolfx marked this pull request as draft August 10, 2026 19:44
@alvarowolfx
alvarowolfx marked this pull request as ready for review August 10, 2026 20:14
Comment thread src/bigquery/src/query/query_handle.rs Outdated
Comment thread src/bigquery/src/query/query_handle.rs Outdated
Comment thread src/bigquery/src/query/query_handle.rs Outdated
Comment thread src/bigquery/src/query/query_handle.rs Outdated
Comment thread src/bigquery/src/query/query_handle.rs Outdated
Comment thread src/bigquery/src/query/run_query.rs Outdated
Comment thread src/bigquery/src/query/run_query.rs Outdated
Comment thread src/bigquery/src/query/run_query.rs Outdated
Comment thread src/bigquery/src/query/run_query.rs Outdated
Comment thread src/bigquery/src/query/run_query.rs Outdated
@alvarowolfx
alvarowolfx requested a review from dbolduc August 11, 2026 20:18
@alvarowolfx
alvarowolfx merged commit 1ece1b1 into googleapis:main Aug 12, 2026
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the BigQuery API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants