-
Notifications
You must be signed in to change notification settings - Fork 1.7k
refactor(bigframes): make executor internals async #17093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
0104b9b
refactor(bigframes): make executor internals async
TrevorBergeron f166cd9
fixes
TrevorBergeron 63af7c5
deal with threadlocal config on worker threads
TrevorBergeron 67427b3
Merge remote-tracking branch 'origin/main' into tbergeron_async_exec
TrevorBergeron 20044ae
lint
TrevorBergeron f13e16d
more threaded config fixes
TrevorBergeron d5c861d
fixes
TrevorBergeron e38f0c6
fix
TrevorBergeron b2463ce
lint tests
TrevorBergeron 0774463
fix mypy issue
TrevorBergeron File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -55,11 +55,6 @@ def create_job_configs_labels( | |
| if job_configs_labels is None: | ||
| job_configs_labels = {} | ||
|
|
||
| # If the user has labels they wish to set, make sure we set those first so | ||
| # they are preserved. | ||
| for key, value in bigframes.options.compute.extra_query_labels.items(): | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Did we move this feature somewhere else? Edit: Yes. ExecutionSpec now reads this config. |
||
| job_configs_labels[key] = value | ||
|
|
||
| if api_methods and "bigframes-api" not in job_configs_labels: | ||
| job_configs_labels["bigframes-api"] = api_methods[0] | ||
| del api_methods[0] | ||
|
|
@@ -230,7 +225,9 @@ def format_option(key: str, value: Union[bool, str]) -> str: | |
| return f"{key}={repr(value)}" | ||
|
|
||
|
|
||
| def add_and_trim_labels(job_config, session=None): | ||
| def add_and_trim_labels( | ||
| job_config, session=None, extra_query_labels: Optional[Mapping[str, str]] = None | ||
| ): | ||
| """ | ||
| Add additional labels to the job configuration and trim the total number of labels | ||
| to ensure they do not exceed MAX_LABELS_COUNT labels per job. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may eventually cause trouble. I've experienced having the main thread be the only one that can apply GUI updates in some frameworks, but I suppose we can address that (e.g. by having an option or something to run on the same thread as the original), but should be fine for the current use case of printing to stdout/stderr.