Skip to content

refactor(bigframes): Introduce GoogleSqlScalarOp#17037

Open
TrevorBergeron wants to merge 3 commits into
mainfrom
tbergeron_googlesql_op
Open

refactor(bigframes): Introduce GoogleSqlScalarOp#17037
TrevorBergeron wants to merge 3 commits into
mainfrom
tbergeron_googlesql_op

Conversation

@TrevorBergeron
Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@TrevorBergeron TrevorBergeron requested review from a team as code owners May 12, 2026 00:58
@TrevorBergeron TrevorBergeron requested review from tswast and removed request for a team May 12, 2026 00:58
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces GoogleSqlScalarOp to provide a more direct mapping between BigFrames operations and GoogleSQL functions, refactoring several geography and mathematical operations to use this new infrastructure. It also adds support for omitted optional arguments across the expression and compilation layers for both Ibis and sqlglot. Feedback identifies several critical implementation errors in the Ibis compiler registry, including incorrect list methods, return type mismatches, and logic errors in argument indexing. Additionally, there are issues with missing imports, incorrect type hints, and consistent typos in the 'omitted' property across the codebase.

Comment thread packages/bigframes/bigframes/core/compile/ibis_compiler/scalar_op_registry.py Outdated
Comment thread packages/bigframes/bigframes/operations/googlesql.py Outdated
Comment thread packages/bigframes/bigframes/operations/googlesql.py Outdated
Comment thread packages/bigframes/third_party/bigframes_vendored/ibis/expr/operations/generic.py Outdated
Comment thread packages/bigframes/bigframes/operations/googlesql.py Outdated
Comment thread packages/bigframes/third_party/bigframes_vendored/ibis/expr/operations/core.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant