chore: migrate core/paginator to Jest#8317
Draft
pearigee wants to merge 11 commits into
Draft
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request migrates the core/paginator package from Mocha, Sinon, and Istanbul to Jest. Changes include updating package.json dependencies, adding a jest.config.js, and refactoring test files to use Jest's mocking and assertion APIs. A new migration guide was also introduced. Reviewer feedback recommends adding clearMocks: true to the Jest configuration to prevent mock call history leakage and suggests using async/await with the .resolves matcher for more idiomatic asynchronous tests.
…hub.com/googleapis/google-cloud-node into pearigee-migrate-core-paginator-to-jest
…hub.com/googleapis/google-cloud-node into pearigee-migrate-core-paginator-to-jest
This reverts commit 5bf3fa9.
This reverts commit c2bd98b.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a prototype migrating the core/paginaor tests to Jest (significantly reducing the need for additional test dependencies).