feat: port GDCH credentials support to Node.js Auth SDK#8301
Open
macastelaz wants to merge 5 commits into
Open
feat: port GDCH credentials support to Node.js Auth SDK#8301macastelaz wants to merge 5 commits into
macastelaz wants to merge 5 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the GdchClient to support Google Distributed Cloud Hosted (GDCH) credentials, including token exchange logic using JWT assertions and integration into the GoogleAuth class. Feedback focuses on optimizing performance by using asynchronous file operations for CA certificates and replacing new Date().getTime() with Date.now() for consistency.
Comment on lines
+183
to
+184
| const ca = fs.readFileSync(this.caCertPath); | ||
| requestOpts.agent = new https.Agent({ ca }); |
Contributor
There was a problem hiding this comment.
Using fs.readFileSync in an async method blocks the event loop. It is recommended to use the asynchronous fs.promises.readFile instead. Additionally, consider caching the https.Agent or the CA certificate buffer to avoid re-reading the file and re-creating the agent on every token refresh.
Suggested change
| const ca = fs.readFileSync(this.caCertPath); | |
| requestOpts.agent = new https.Agent({ ca }); | |
| const ca = await fs.promises.readFile(this.caCertPath); | |
| requestOpts.agent = new https.Agent({ ca }); |
…opics. 1) Async CA file reading 2) Token response validation 3) Option synchronization and 4) Expanded unit test coverage.
…manual testing in a GDCH environment. These fixes include: 1) Correcting the type of the credential being parsed from 'gdch_credentials' to 'gdch_service_account' which is the type generated in the SA file. 2)Changing the audience property in token exchange to get the STS-Bearer instead of just Bearer token. 3) Override the requestAsync method to ensure client operations automatically read and trust custom CA certificate files specificied in the credentials json 'ca_cert_path'. 4) Fixed unit test oversight of incorrect call to nockScope.restore().
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for GDCH Credentials to the Node.js Auth SDK
Manually tested - details in go/node-js-gdch-manual-test
Fixes #8289