Fix swapped performance metrics in RetBleed benchmark table#396
Open
2045castor wants to merge 1 commit into
Open
Fix swapped performance metrics in RetBleed benchmark table#3962045castor wants to merge 1 commit into
2045castor wants to merge 1 commit into
Conversation
Author
|
@matrizzo Since you added the original documentation, could you take a quick look? While studying this repository, I noticed that the performance data (MEAN, MEDIAN, STDDEV) for retbleed=off and retbleed=ibpb appear to be accidentally swapped in the benchmark table. The calculated Overhead percentages strongly support this. Could you please review and confirm if this is the case? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR corrects a data entry error in the benchmark results table where the raw performance metrics (MEAN, MEDIAN, STDDEV) for "retbleed=off" and "retbleed=ibpb" were accidentally swapped.
The original table illogically showed the heaviest mitigation (ibpb) yielding the highest performance, while the unmitigated baseline (off) had the lowest. The correctness of this fix is verified by the existing Overhead column: calculating a 57.74 percent overhead from a true baseline of 91385.800 mathematically yields the 38619.000 result.
This commit simply maps the raw data back to the correct rows to align with the calculated overheads and expected hardware behavior.