fix(python): accept RawIOBase streams in identify_stream (#1403) - #1426
Open
MeiSiristhebest wants to merge 1 commit into
Open
fix(python): accept RawIOBase streams in identify_stream (#1403)#1426MeiSiristhebest wants to merge 1 commit into
MeiSiristhebest wants to merge 1 commit into
Conversation
identify_stream() rejected valid BinaryIO streams such as io.FileIO (an io.RawIOBase) with a TypeError, even though the BinaryIO type hint accepts them. Broaden the runtime check to also accept io.RawIOBase so the behavior matches the documented type contract. Fixes google#1403
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Magika.identify_stream()previously rejected validBinaryIOstreams such asio.FileIO(anio.RawIOBase) with aTypeError, even though the type hint acceptsBinaryIO. This made statically-typed usage likem.identify_stream(io.FileIO(path, "rb"))crash at runtime.io.RawIOBase, aligning behavior with the documentedBinaryIOcontract (see identify_stream() crashes on valid BinaryIO streams (like io.FileIO) #1403).Test plan
tests/test_identify_stream_binaryio.pycoveringio.FileIO,open(path, "rb"),io.BytesIO(all accepted) andio.StringIO(still rejected with a helpful error).ruff check/ruff format --check/mypy src/magika tests/ full pytest suite (-m "not slow") pass locally.Fixes #1403