fix(eval): handle unevaluated final response v2 results#5728
Open
pragnyanramtha wants to merge 1 commit into
Open
fix(eval): handle unevaluated final response v2 results#5728pragnyanramtha wants to merge 1 commit into
pragnyanramtha wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a small aggregation edge case in
FinalResponseMatchV2Evaluator: when every per-invocation result is skipped or not evaluated, the evaluator currently divides by zero while computing the overall score.Root Cause
aggregate_invocation_results()filters out results whosescoreisNoneor whoseeval_statusisNOT_EVALUATED, but it unconditionally computes:If all judge samples fail to produce a usable score,
num_evaluatedremains0and evaluation crashes instead of returning a not-evaluated aggregate result. Other ADK evaluators handle this condition by returningoverall_score=Noneandoverall_eval_status=NOT_EVALUATED.Change
EvaluationResultwithoverall_score=Noneandoverall_eval_status=NOT_EVALUATEDwhen no FinalResponseMatchV2 invocation results are evaluable.Validation
uv sync --extra test uv run pytest tests/unittests/evaluation/test_final_response_match_v2.pyResult:
18 passed, 20 warnings.Full unit suite was not run; this patch is limited to FinalResponseMatchV2 aggregation and its targeted unit test file.