feat: implement streaming support for Claude model#1221
Open
serelli wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
I have signed the CLA! |
1 similar comment
Author
|
I have signed the CLA! |
Switch Claude.generateContent() to use the Anthropic SDK's createStreaming() API when stream=true, replacing the previous non-streaming fallback (which had a TODO: Switch to streaming API comment). - Text deltas are emitted immediately as partial LlmResponses - Tool use JSON is accumulated across inputJson deltas and emitted as a function call LlmResponse on contentBlockStop - messageStop emits a turnComplete=true sentinel - StreamResponse is always closed via Flowable.using() - Extracted buildMessageCreateParams() to deduplicate param logic Add 6 unit tests covering text streaming, tool call accumulation, mixed text+tool responses, empty streams, and invalid JSON fallback.
d856d37 to
a450dee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Claude.generateContent()to use the Anthropic SDK'screateStreaming()API whenstream=true, replacing the previous non-streaming fallback (which had aTODO: Switch to streaming APIcomment)LlmResponses withpartial=trueinputJsondeltas and emitted as a function callLlmResponseoncontentBlockStopmessageStopemits aturnComplete=truesentinelStreamResponseis always closed viaFlowable.using()to prevent resource leaksbuildMessageCreateParams()to deduplicate param-building logic shared by both streaming and non-streaming pathsTest plan
testStreaming_textChunksEmittedAsPartialResponses— text deltas becomepartial=trueresponses in ordertestStreaming_messageStopEmitsTurnComplete—messageStopevent setsturnComplete=truetestStreaming_toolCallAccumulatedAndEmittedOnBlockStop— tool JSON accumulates across deltas, emits complete function call on block stoptestStreaming_mixedTextAndToolCall— interleaved text + tool call in same stream produces correct ordered responsestestStreaming_emptyStream_producesNoResponses— empty event stream produces no outputtestStreaming_toolCallWithInvalidJson_fallsBackToEmptyArgs— malformed JSON logs a warning and falls back to empty args map