Skip to content

fix: run tools concurrently in PARALLEL ToolExecutionMode#1220

Open
copybara-service[bot] wants to merge 1 commit into
mainfrom
test_920982161
Open

fix: run tools concurrently in PARALLEL ToolExecutionMode#1220
copybara-service[bot] wants to merge 1 commit into
mainfrom
test_920982161

Conversation

@copybara-service
Copy link
Copy Markdown

fix: run tools concurrently in PARALLEL ToolExecutionMode

@kiwigitops
Copy link
Copy Markdown

The production change makes sense, but the new concurrency tests are still mostly wall-clock based. durationMillis < toolCount * sleepMillis proves the calls are not fully sequential, but it would also pass if a 5-tool run only executed two tools at a time, and it can get noisy under CI load.

A more direct regression would have SleepingTool record active-call count or wait on a shared latch/barrier, then assert that at least two tool invocations overlap before any of them are released. That would test the scheduler behavior without depending as much on timing margins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants