Skip to content

this portion of attention code looks incorrect #245

Description

@ava6969

attention_mlp = basic.BatchApply( mlp.MLP([self._mem_size] * self._attention_mlp_layers))

for _ in range(self._num_blocks): attended_memory = self._multihead_attention(memory)

shouldnt it be this

attended_memory = memory
for _ in range(self._num_blocks):
attended_memory = self._multihead_attention(attended_memory)

i know memory isn't changed in that function too, so isn't this expected to be redundant.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions