Skip to content

Fix godoc in suite_test template of testing plugin#257

Merged
raphael merged 2 commits into
v3from
testing-suite-test-godoc-fix
May 27, 2026
Merged

Fix godoc in suite_test template of testing plugin#257
raphael merged 2 commits into
v3from
testing-suite-test-godoc-fix

Conversation

@tchssk
Copy link
Copy Markdown
Member

@tchssk tchssk commented May 27, 2026

This pull request updates the naming conventions for generated test harness helpers and their documentation comments to use proper Go-style capitalization and struct names, improving consistency and readability across the codebase.

Test harness naming and documentation consistency:

  • Updated the documentation comment in suite_test.go.tpl to use .Service.StructName instead of .Service.Name, ensuring the generated comment references the correct struct name.
  • Corrected the function name and comment in calculator_suite_test.go from RuncalculatorHarness to RunCalculatorHarness, matching Go naming conventions.
  • Corrected the function name and comment in test_http_grpc_suite_test.go from Runtest-http-grpcHarness to RunTestHTTPGrpcHarness, using proper capitalization and removing dashes.
  • Corrected the function name and comment in test_jsonrpc_suite_test.go from Runtest-jsonrpcHarness to RunTestJsonrpcHarness, using proper capitalization and removing dashes.

@tchssk tchssk marked this pull request as ready for review May 27, 2026 11:51
@raphael
Copy link
Copy Markdown
Member

raphael commented May 27, 2026

This is great, thank you!

@raphael raphael merged commit 55c37e9 into v3 May 27, 2026
5 checks passed
@raphael raphael deleted the testing-suite-test-godoc-fix branch May 27, 2026 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants