feat: support x509 commit signing#2844
Open
kaden-l-nelson wants to merge 1 commit into
Open
Conversation
kaden-l-nelson
force-pushed
the
feat/x509-signing-method
branch
3 times, most recently
from
35ef709 to
8e226dd
Compare
Author
|
@extrawurst may you review this PR? |
kaden-l-nelson
force-pushed
the
feat/x509-signing-method
branch
from
8e226dd to
35537d5
Compare
kaden-l-nelson
force-pushed
the
feat/x509-signing-method
branch
from
35537d5 to
6d14f1a
Compare
kaden-l-nelson
force-pushed
the
feat/x509-signing-method
branch
from
6d14f1a to
4acae06
Compare
extrawurst
reviewed
Jun 23, 2026
extrawurst
left a comment
extrawurst
left a comment
Collaborator
There was a problem hiding this comment.
lgtm just a few comments
|  | ||
|
|
||
| ### Added | ||
| * support x509 commit signing [[@kaden-l-nelson](https://github.com/kaden-l-nelson)] ([#2514](https://github.com/gitui-org/gitui/issues/2514)) |
Collaborator
There was a problem hiding this comment.
this needs to go into the unreleased section
| } | ||
|
|
||
| #[test] | ||
| fn test_x509_program_defaults() -> Result<()> { |
Collaborator
There was a problem hiding this comment.
these are just config tests would you feel up to provide a linux only e2e test that actually setsup the tools and executes this whole flow?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #2514.
It changes the following:
I followed the checklist:
make checkwithout errors