Remove suggestion to use already deprecated options - #42610
Remove suggestion to use already deprecated options#42610Aleksander-Karlsson wants to merge 3 commits into
Conversation
According to Dependency review action docs this is already deprecated, and might be removed >⚠️ This option is deprecated for possible removal in the next major release. See [Deprecate the deny-licenses option github#938](actions/dependency-review-action#938) for more information. <br> Contains a list of prohibited licenses. The action will fail on pull requests that introduce dependencies with licenses that match the list. ref section https://github.com/actions/dependency-review-action/blob/main/README.md#configuration
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksNote: Please update the URL for your staging server or codespace. The table shows the files in the Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server 🤖 This comment is automatically generated. |
|
@Aleksander-Karlsson This looks like it's probably correct based on the conversation you linked, but I'm going to have to check in with the people involved to ensure that this is how they want the documentation to read. |
|
A stale label has been added to this pull request because it has been open 30 days with no activity. If you think this pull request should remain open, please add a new comment. |
|
A stale label has been added to this pull request because it has been open 30 days with no activity. If you think this pull request should remain open, please add a new comment. |
|
@Aleksander-Karlsson Please accept my apologies for the late reply here. We'll need to take this internally to fix, to verify with the team concerned when they'd like us to make those changes to the public docs. As such, I'm afraid I'll need to close this PR. Thank you very much for your interest in the GitHub docs |
Why:
To keep documentation up to date with Dependency review action.
According to Dependency review action docs this is already deprecated, and might be removed.
ref section https://github.com/actions/dependency-review-action/blob/main/README.md#configuration
Closes:
What's being changed (if available, include any code snippets, screenshots, or gifs):
Removed the bullet point suggesting that using deny-list instead of allow-list for licenses is best practice.
Check off the following: