Conversation
paldepind
force-pushed
the
rust/rust-analyzer-update-docs
branch
from
September 22, 2026 11:51
7e5ea2f to
1da39a2
Compare
paldepind
force-pushed
the
rust/rust-analyzer-update-docs
branch
from
September 23, 2026 05:08
8ccccba to
cfef83b
Compare
paldepind
force-pushed
the
rust/rust-analyzer-update-docs
branch
from
September 23, 2026 07:11
cfef83b to
aab542b
Compare
paldepind
force-pushed
the
rust/rust-analyzer-update-docs
branch
from
September 29, 2026 13:16
aab542b to
09f793f
Compare
paldepind
marked this pull request as ready for review
September 30, 2026 06:47
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The workflow excludes relevant test sources, and the updater can silently retain stale source metadata.
Review effort: Balanced
Findings: 2
Open (3)
What changed in this PR
Automates rust-analyzer source-tag and integrity updates while broadening workflow edit permissions.
Changes:
- Updates instructions and updater automation.
- Extracts Bazel integrity into an updater-managed constant.
- Expands agentic workflow file permissions.
| File | Description |
|---|---|
rust/updating-rust-analyzer.md |
Documents source archive updates and renumbers steps. |
rust/scripts/update_rust_analyzer.py |
Updates source tag and integrity automatically. |
MODULE.bazel |
Adds the managed integrity constant. |
.github/workflows/update-rust-analyzer.md |
Expands allowed shared-source paths. |
.github/workflows/update-rust-analyzer.lock.yml |
Regenerates the compiled workflow. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Refactor regex replacements for RUST_ANALYZER_SRC_TAG and RUST_ANALYZER_SRC_INTEGRITY to ensure exactly one assignment is made for each. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two (unrelated) changes to the rust-analyzer update automation:
When rust-analyzer is updated the
RUST_ANALYZER_SRC_TAGinMODULE.bazelneeds to be updated. See e.g., cb459eb from the latest update. This PR adds a new step 2 explaining this in the update instructions and the script is extended to do this automatically.Add some more globs to
allowed-filesfiles for the agentic workflow. The comment explains why they're needed.