C#: TSP note and compilation info for unreachable feeds. - #22364
Draft
michaelnebel wants to merge 3 commits into
Draft
C#: TSP note and compilation info for unreachable feeds.#22364michaelnebel wants to merge 3 commits into
michaelnebel wants to merge 3 commits into
Conversation
michaelnebel
force-pushed
the
csharp/tspreportbadfeeds
branch
5 times, most recently
from
August 19, 2026 13:31
d54611d to
a7acd5c
Compare
michaelnebel
force-pushed
the
csharp/tspreportbadfeeds
branch
from
August 21, 2026 09:19
a7acd5c to
8c6d158
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Improves C# buildless diagnostics by identifying unreachable explicitly configured NuGet feeds.
Changes:
- Reports unreachable feeds in warnings, tool status diagnostics, and compilation metadata.
- Updates integration queries and expected results to support string-valued metadata.
- Adds a change note.
Show a summary per file
| File | Description |
|---|---|
csharp/ql/lib/change-notes/2026-08-18-tsp-nuget-feed-reachability.md |
Documents the diagnostic enhancement. |
csharp/ql/integration-tests/posix/standalone_dependencies_nuget_config_fallback/diagnostics.expected |
Expects the unreachable fallback feed. |
csharp/ql/integration-tests/posix/standalone_dependencies_nuget_config_fallback/CompilationInfo.ql |
Reads string metadata values. |
csharp/ql/integration-tests/posix/standalone_dependencies_nuget_config_fallback/CompilationInfo.expected |
Expects unreachable-feed metadata. |
csharp/ql/integration-tests/posix/standalone_dependencies_nuget_config_error/CompilationInfo.ql |
Reads string metadata values. |
csharp/ql/integration-tests/posix/standalone_dependencies_nuget_config_error/CompilationInfo.expected |
Expects the failed feed URL. |
csharp/ql/integration-tests/posix/standalone_dependencies_nuget_config_error_timeout/diagnostics.expected |
Expects multiple unreachable feeds. |
csharp/ql/integration-tests/posix/standalone_dependencies_nuget_config_error_timeout/CompilationInfo.ql |
Reads string metadata values. |
csharp/ql/integration-tests/posix/standalone_dependencies_nuget_config_error_timeout/CompilationInfo.expected |
Expects multiple failed feed URLs. |
csharp/ql/integration-tests/posix/standalone_dependencies_nuget_clear/CompilationInfo.ql |
Reads string metadata values. |
csharp/ql/integration-tests/posix/standalone_dependencies_nuget_clear/CompilationInfo.expected |
Updates string-formatted expectations. |
csharp/ql/integration-tests/all-platforms/standalone_winforms/CompilationInfo.ql |
Reads string metadata values. |
csharp/ql/integration-tests/all-platforms/standalone_winforms/CompilationInfo.expected |
Updates string-formatted expectations. |
csharp/ql/integration-tests/all-platforms/standalone_slnx/CompilationInfo.ql |
Reads string metadata values. |
csharp/ql/integration-tests/all-platforms/standalone_slnx/CompilationInfo.expected |
Updates string-formatted expectations. |
csharp/ql/integration-tests/all-platforms/standalone_resx/CompilationInfo.ql |
Reads string metadata values. |
csharp/ql/integration-tests/all-platforms/standalone_resx/CompilationInfo.expected |
Updates string-formatted expectations. |
csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/NugetPackageRestorer.cs |
Computes and reports unreachable explicit feeds. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 18/18 changed files
- Comments generated: 1
- Review effort level: Balanced
Comment on lines
+548
to
+550
| var unreachableFeedList = string.Join(", ", orderedUnreachableFeeds); | ||
| logger.LogWarning($"Found unreachable NuGet feeds in C# analysis with build-mode 'none': {unreachableFeedList}. This may cause missing dependencies in the analysis."); | ||
| compilationInfoContainer.CompilationInfos.Add(("Unreachable NuGet feeds", unreachableFeedList)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, the tool status page note is improved to contain unreachable explicit feeds.