Publish v19 charts and testing surfaces - #789
Conversation
|
Warning Review limit reached
Next review available in: 32 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (13)
📝 WalkthroughWalkthroughThe PR adds a bounded graph neighborhood observer and an isolated real-Git Runtime testing harness, exposes both through new package subpaths, updates build and publication configuration, and extends API references, migration guidance, type checks, and boundary tests. ChangesGraph chart observers
Runtime testing harness
Published entrypoints and reference coverage
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant Consumer
participant GraphObservers
participant Runtime
Consumer->>GraphObservers: create graph.neighborhood observer
GraphObservers->>Runtime: request bounded neighborhood reading
Runtime-->>GraphObservers: return chart reading value
GraphObservers-->>Consumer: return frozen GraphNeighborhoodChart
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/domain/api/GraphChartObservers.ts`:
- Around line 22-95: Replace the structural GraphNeighborhoodChart and
GraphNeighborhoodEdge types with exported frozen domain classes that validate
constructor inputs and support instanceof checks. Update decodeNeighborhoodChart
and decodeNeighborhoodEdge to construct these classes instead of freezing
literals and casting them, while preserving existing validation, nested edge
freezing, and public fields. Update affected tests to assert runtime class
identity and constructor validation.
In `@src/testing/RuntimeHarness.ts`:
- Around line 1-6: Update RuntimeHarness and its temporary-directory and Git
setup paths to receive host I/O through constructor-injected ports instead of
importing node:fs/promises, node:os, node:path, or openDefaultGitPlumbing
directly. Define or reuse the appropriate port and adapter wiring at the
composition boundary, while preserving the harness’s existing behavior;
alternatively, explicitly mark this testing surface as an approved adapter
exemption if it is intentionally allowed to own these capabilities.
- Around line 31-45: Update the close method in RuntimeHarness so the closed
state is committed only after both runtime.close() and temporary-directory
removal succeed. Preserve idempotent behavior for successful cleanup, but ensure
a rejection leaves the harness retryable rather than silently returning on
subsequent close calls.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: adf9e2c7-bd0d-4880-80e2-0db7c7ac6984
📒 Files selected for processing (17)
charts.tsdocs/migrations/v19/README.mddocs/topics/api/README.mddocs/topics/reference.mdjsr.jsonpackage.jsonscripts/check-source-backed-reference.tsscripts/storage-ownership-policy.tssrc/domain/api/GraphChartObservers.tssrc/testing/RuntimeHarness.tstest/type-check/v19-subpaths.tstest/unit/domain/GraphChartObservers.test.tstest/unit/scripts/v19-public-api-boundary.test.tstest/unit/testing/RuntimeHarness.test.tstesting.tstsconfig.publish.jsontsconfig.src.json
📜 Review details
⏰ Context from checks skipped due to timeout. (5)
- GitHub Check: test-deno
- GitHub Check: v19 base/head performance
- GitHub Check: coverage-threshold
- GitHub Check: test-node (22)
- GitHub Check: preflight
🧰 Additional context used
📓 Path-based instructions (4)
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{ts,tsx,js,jsx}: Do not use direct imports fromsrc/infrastructure/**insrc/domain/**orsrc/ports/**; depend on a port instead.
Do not use direct Node built-ins insrc/domain/**orsrc/ports/**; use a port instead.
Files:
test/unit/domain/GraphChartObservers.test.tstesting.tscharts.tstest/unit/scripts/v19-public-api-boundary.test.tstest/unit/testing/RuntimeHarness.test.tsscripts/storage-ownership-policy.tssrc/testing/RuntimeHarness.tssrc/domain/api/GraphChartObservers.tstest/type-check/v19-subpaths.tsscripts/check-source-backed-reference.ts
src/**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (AGENTS.md)
src/**/*.{ts,tsx,js,jsx}: Do not introduceany,as any,as unknown as,unknown(outside adapters),Record<string, unknown>(outside adapters),*Likeplaceholder types,JSON.parse/JSON.stringify(outside adapters),fetch(outside adapters),process.env(outside adapters),@ts-ignore, orz.any()in core code; use validated boundary models and ports instead.
Use constructor-injected ports for external capabilities; do not rely on ambient dependencies for I/O, clocks, persistence, or entropy.
Do not createutils.ts,helpers.ts,misc.ts, orcommon.ts; name files after the actual concept they model.
Prefer one file per class, type, or object; if a file accumulates peer concepts, split it.
Keep helper corridors, fake shape trust, transitional duplication, and compile-time theater out of the codebase; runtime-honest TypeScript must reflect actual behavior.
No enum usage; prefer runtime-backed domain forms and unions.
Do not use boolean trap parameters; prefer named option objects or separate methods.
Avoid magic strings or numbers when a named constant should exist.
Keep domain bytes asUint8Array;Bufferbelongs in infrastructure adapters.
Files:
src/testing/RuntimeHarness.tssrc/domain/api/GraphChartObservers.ts
src/domain/**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (AGENTS.md)
src/domain/**/*.{ts,tsx,js,jsx}: Insrc/domain/**, do not useDate.now(),new Date(),Date(),performance.now(),Math.random(),crypto.randomUUID(),crypto.getRandomValues(),setTimeout,setInterval, rawnew Error(...)/new TypeError(...), or direct imports from Node built-ins; time, entropy, and external capabilities must enter through ports or parameters, and domain errors should extendWarpError.
Construct domain objects only in core when doing so establishes validated runtime truth; do not build infrastructure adapters, host APIs, persistence implementations, wall clocks, or entropy sources inside core.
Prefer discriminated unions and explicit result types instead of boolean-flag bags, and model expected failures as return values rather than exceptions.
src/domain/must not import host APIs or Node-specific globals; hexagonal architecture boundaries are mandatory.
Domain code must not use the wall clock directly; time must enter through a port or parameter.
Files:
src/domain/api/GraphChartObservers.ts
src/domain/**/!(*.test).{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (AGENTS.md)
Use explicit domain concepts with validated constructors,
Object.freeze, andinstanceofdispatch; domain objects should be runtime-backed nouns, not ad hoc shape bags.
Files:
src/domain/api/GraphChartObservers.ts
🧠 Learnings (1)
📚 Learning: 2026-03-04T12:08:30.347Z
Learnt from: flyingrobots
Repo: git-stunts/git-warp PR: 63
File: package.json:126-126
Timestamp: 2026-03-04T12:08:30.347Z
Learning: Vitest 4 removes vite-node as a dependency and rewrites its pool system. Do not flag the absence of vite-node in package.json or lockfiles as an error for Vitest 4 projects. Use this as a general guideline: if a project uses Vitest 4, missing vite-node is expected and correct; only flag issues if there is evidence the project is not using Vitest 4 or if vite-node is explicitly required by the project.
Applied to files:
package.json
🔇 Additional comments (16)
test/unit/domain/GraphChartObservers.test.ts (1)
8-74: LGTM!charts.ts (1)
9-15: LGTM!docs/topics/api/README.md (1)
527-539: LGTM!testing.ts (1)
8-12: LGTM!test/type-check/v19-subpaths.ts (1)
4-26: LGTM!Also applies to: 41-49, 58-64
docs/topics/reference.md (1)
18-26: LGTM!Also applies to: 144-186
test/unit/scripts/v19-public-api-boundary.test.ts (1)
227-264: LGTM!docs/migrations/v19/README.md (1)
5-6: LGTM!Also applies to: 306-309, 345-346
src/testing/RuntimeHarness.ts (1)
8-16: LGTM!Also applies to: 18-30, 47-50, 53-65
test/unit/testing/RuntimeHarness.test.ts (1)
1-3: LGTM!Also applies to: 6-10, 12-29
jsr.json (1)
11-14: LGTM!Also applies to: 15-22
package.json (1)
48-57: LGTM!tsconfig.publish.json (1)
16-17: LGTM!tsconfig.src.json (1)
8-9: LGTM!scripts/storage-ownership-policy.ts (1)
7-8: LGTM!scripts/check-source-backed-reference.ts (1)
232-232: LGTM!Also applies to: 245-246, 269-273
Release Preflight
If this PR is from a |
Release Preflight
If this PR is from a |
1 participant
Summary
/chartsobservers and the disposable real-Git/testingruntime harness.Issue
Refs #712
Test plan
ADR checks