Conversation
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
8345905 to
2b97795
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2b97795. Configure here.
|
|
||
| if dest_data.len() > MAX_DATA_BAG_NODES { | ||
| break; | ||
| } |
There was a problem hiding this comment.
Data bag limit off by one
Low Severity
load_data_bag inserts first and then breaks when dest_data.len() is greater than MAX_DATA_BAG_NODES, so the map can hold 100,001 entries instead of the intended 100,000. The RuntimeProperties custom-node path compares before insert and stays within the cap.
Reviewed by Cursor Bugbot for commit 2b97795. Configure here.
|
I think adding a test, if possible, would be nice. Also left a comment on the internal ticket. |
| let value = child.value::<String>()?.unwrap_or_default(); | ||
| dest_data.insert(name, value); | ||
|
|
||
| if dest_data.len() > MAX_DATA_BAG_NODES { |
There was a problem hiding this comment.
I think this check can be moved to the start of the loop.
…port-one-anonymous-request-oom-kills-relay
3 participants
No description provided.