Skip to content

chore: replace alby mutinynet lsps2 with megalith mutinynet lsp#2469

Open
rolznz wants to merge 1 commit into
masterfrom
chore/megalith-mutinynet-lsps2
Open

chore: replace alby mutinynet lsps2 with megalith mutinynet lsp#2469
rolznz wants to merge 1 commit into
masterfrom
chore/megalith-mutinynet-lsps2

Conversation

@rolznz

@rolznz rolznz commented Jun 28, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Bug Fixes
    • Updated the fallback liquidity provider used on signet when no custom LSPS2 source or peer suggestion is available.
    • Switched to a newer default endpoint and connection details for improved compatibility and reliability.

@rolznz rolznz added this to the v1.24.0 milestone Jun 28, 2026
@coderabbitai

coderabbitai Bot commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6f98f225-18a5-4cd0-9d06-306cb349e042

📥 Commits

Reviewing files that changed from the base of the PR and between 222031a and 9a72a66.

📒 Files selected for processing (1)
  • lnclient/ldk/ldk.go

📝 Walkthrough

Walkthrough

In lnclient/ldk/ldk.go, the hardcoded signet fallback LSPS2 liquidity source in NewLDKService was changed from the Alby LSP (Mutinynet) endpoint to the Megalith LSP 2 (Mutinynet) endpoint, updating the pubkey/host/port value and its comment.

Signet Fallback LSP Update

Layer / File(s) Summary
Signet default LSPS2 endpoint
lnclient/ldk/ldk.go
Replaces the Alby LSP (Mutinynet) pubkey@host:port with the Megalith LSP 2 (Mutinynet) equivalent and updates the associated comment.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A hop and a skip, the LSP has changed,
From Alby to Megalith, endpoints rearranged.
On signet we test with mutinynet flair,
New pubkey and port floating through the air.
🐇 All is well in the liquidity lair!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately describes the main change: swapping the Mutinynet LSPS2 fallback from Alby to Megalith.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/megalith-mutinynet-lsps2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant