PB-2357: add missing .html suffix. - #171
Merged
Merged
Conversation
adk-swisstopo
marked this pull request as ready for review
July 29, 2026 08:48
asteiner-swisstopo
approved these changes
Jul 29, 2026
asteiner-swisstopo
left a comment
asteiner-swisstopo
left a comment
Contributor
There was a problem hiding this comment.
Works as expected, thanks!
Maybe not ideal as now you have to remember in which context to add the ".html". But it's ok, there are examples and it's not going to change often.
Member
Author
With https://github.com/geoadmin/infra-e2e-tests/pull/428 you won't have to remember as test breakage will remind you :) I agree it would be better to get rid of that hand-written HTML, or at least the hand-written links. But I am unclear on how to do that and presumably there was a reason for doing it like this in the first place? |
The server side does not do any URL translation (i.e. no suffix is automatically added to URLs without JavaScript). Some links are managed manually through hand-written HTML. These links are missing the `.html` suffix and are thus broken for clients that do not support JavaScript. This change adds the `.html` suffix to the manually-managed links.
adk-swisstopo
force-pushed
the
PB-2357-html
branch
from
July 29, 2026 13:52
051f3c5 to
84028f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server side does not do any URL translation (i.e. no suffix is automatically added to URLs without JavaScript). Some links are managed manually through hand-written HTML. These links are missing the
.htmlsuffix and are thus broken for clients that do not support JavaScript.This change adds the
.htmlsuffix to the manually-managed links.Test link