Store factorization of minimal & characteristic poly#53
Draft
fingolfin wants to merge 1 commit into
Draft
Conversation
Many applications need a factorization of these polynomials. It wasteful to compute it and then discard it again.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #53 +/- ##
==========================================
+ Coverage 60.62% 60.69% +0.06%
==========================================
Files 9 9
Lines 5729 5739 +10
==========================================
+ Hits 3473 3483 +10
Misses 2256 2256
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many applications need a factorization of these polynomials. It wasteful to compute it and then discard it again.
--
I started this back in August and don't want it to be forgotten. Not sure if this version already fully works, and there is no test, hence I am putting on a draft label.
Ideally a similar change would be applied to GAP's methods for computing min/char polynomials, but since the ones in cvec are faster and so I am always using them anyway, and since it was very, very easy to do so here, I did not feel motivated.