Skip to content

Store factorization of minimal & characteristic poly#53

Draft
fingolfin wants to merge 1 commit into
masterfrom
mh/factored-minpoly
Draft

Store factorization of minimal & characteristic poly#53
fingolfin wants to merge 1 commit into
masterfrom
mh/factored-minpoly

Conversation

@fingolfin
Copy link
Copy Markdown
Member

Many applications need a factorization of these polynomials. It wasteful to compute it and then discard it again.

--

I started this back in August and don't want it to be forgotten. Not sure if this version already fully works, and there is no test, hence I am putting on a draft label.

Ideally a similar change would be applied to GAP's methods for computing min/char polynomials, but since the ones in cvec are faster and so I am always using them anyway, and since it was very, very easy to do so here, I did not feel motivated.

Many applications need a factorization of these polynomials.
It wasteful to compute it and then discard it again.
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.69%. Comparing base (313cb17) to head (9cd1e3f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   60.62%   60.69%   +0.06%     
==========================================
  Files           9        9              
  Lines        5729     5739      +10     
==========================================
+ Hits         3473     3483      +10     
  Misses       2256     2256              
Files with missing lines Coverage Δ
gap/linalg.gi 60.84% <100.00%> (+0.45%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant